Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

[spec] add missing production to other RelationalExpression SDOs #10

Merged
merged 1 commit into from Jul 17, 2020
Merged

[spec] add missing production to other RelationalExpression SDOs #10

merged 1 commit into from Jul 17, 2020

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jul 15, 2020

@michaelficarra
Copy link
Member

I think you'll need to update 14.9.2.2 and Annex A too.

@ljharb
Copy link
Member Author

ljharb commented Jul 15, 2020

@michaelficarra i updated the PR; Annex A is automatically updated when the SDOs are, but I included it in the PR anyways so that the rendered diffs would show the insertion.

michaelficarra
michaelficarra reviewed Jul 17, 2020
View reviewed changes
spec.emu

<emu-annex id="sec-grammar-summary">
<h1>Grammar Summary</h1>
<emu-annex id="sec-placeholder"><h1>Placeholder to ensure correct annex numbering</h1></emu-annex>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this cause it to be Annex B?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case, there's nested annexes.

@ljharb ljharb merged commit 5c4adf8 into master Jul 17, 2020
@ljharb ljharb deleted the sdo branch July 17, 2020 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ljharb @michaelficarra