Improvements covering a few ongoing issues #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcporter
reviewed
Dec 24, 2019
ljharb
reviewed
Dec 24, 2019
Adds # on each parsing/runtime error example Co-Authored-By: Jordan Harband <ljharb@gmail.com>
rickbutton
reviewed
Dec 30, 2019
rickbutton
reviewed
Dec 30, 2019
rickbutton
approved these changes
Jan 6, 2020
littledan
reviewed
Jan 6, 2020
| const r2 = #{ obj: true ? {} : #{} }; // will fail at runtime as it's not obvious from the parser's perspective that we should fail | ||
| const r3 = #{ method() {} }; // fails at parse time | ||
| ``` | ||
| If you try to use a method definitions as part of a Record, the same behavior is expected, it should fail at runtime (even if we could fail at compile time). |
There was a problem hiding this comment.
Not sure why you removed the examples
littledan
reviewed
Jan 6, 2020
README.md
Outdated
| @@ -344,10 +338,6 @@ We propose to add `JSON.parseImmutable` so we can extract a Record/Tuple type ou | |||
|
|
|||
| The signature of `JSON.parseImmutable` is identical to `JSON.parse` with the only change being in the return type that is now a Record or a Tuple. | |||
|
|
|||
| ## JSON.stringify | |||
There was a problem hiding this comment.
Not sure why this was removed either; it's good to know, even if there's zero spec text corresponding to it.
There was a problem hiding this comment.
It was already specified somewhere else in the file, so this was a duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #40, fixes #74, fixes #88.
If anything is too controversial, I can isolate a commit and discuss it further in an another PR.