-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint staged #9
Lint staged #9
Conversation
heh You beat me to it. My PR is a little lighter weight, mostly by virtue of enforcing lint at in the build step rather than on commit. I don't have much experience with either |
Huh 😛, in German there's a saying that goes "Zwei Dumme, ein Gedanke", which literally translates to "two fools, one thought" but it's meant in a positive way (Google just told me the correct translation is "great minds think alike" which I feel less comfortable with because I'd rather describe myself as a fool than a great mind…) I also don't have a strong opinion on this topic and neither do I have a lot of experience with these tools. I'll happily leave that up for @bcoe to decide 🙇. |
@bcoe I did rebase but don't you think this is kinda redundant now? @broofa's approach and mine were different in two dimensions:
I think we should, for each dimension, decide for one approach:
The difference of 99 vs. 100 is an artifact of how vim handles line wrapping when you set |
|
@broofa my concern was not so much how to manually run this script, my concern was rather that we currently have no automation in place that will ensure that the stuff we merge into master adheres to our conventions… Which is why I went for the |
@ctavan 👋 I just added TravisCI: https://travis-ci.org/bcoe/proposal-standard-module-uuid I think my preference would be that we don't automatically fix the formatting on commit, but that we have a I could be swayed in either direction though. |
Addresses the idea from #8 (comment)
Not sure though how I feel about adding this amount of tooling to something that is mostly just a README 🤷♂
WDYT?