Rename Array#groupBy and Array#groupByToMap to Array#group and Array#groupToMap #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…groupToMap TC39 decided to rename them to avoid web-compat issue[1]. This change follows to it. [1]: tc39/proposal-array-grouping#39
ptomato
approved these changes
Aug 3, 2022
webkit-early-warning-system
pushed a commit
to Constellation/WebKit
that referenced
this pull request
Aug 4, 2022
https://bugs.webkit.org/show_bug.cgi?id=243510 Reviewed by Mark Lam, Justin Michaud, Devin Rousso and Ross Kirsling. We agreed at TC39 to renaming Array#groupBy and Array#groupByToMap to Array#group and Array#groupToMap to keep web-compatibility. This patch renames and enables them, stage-4 progress is tracked in [1]. We also upstreamed test262 fix for this[2]. [1]: tc39/proposal-array-grouping#32 [2]: tc39/test262#3632 * Source/JavaScriptCore/builtins/ArrayPrototype.js: (group): (groupToMap): (groupBy): Deleted. (groupByToMap): Deleted. * Source/JavaScriptCore/runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::finishCreation): * Source/JavaScriptCore/runtime/OptionsList.h: Canonical link: https://commits.webkit.org/253101@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TC39 decided to rename them to avoid web-compat issue1.
This change follows to it.