Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test for o[p] = f() #4052

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Update test for o[p] = f() #4052

merged 2 commits into from
Apr 12, 2024

Conversation

rkirsling
Copy link
Member

@rkirsling rkirsling commented Apr 11, 2024

Update S11.13.1_A7_T3.js now that consensus has been reached on tc39/ecma262#3307.

This ends up basically the same as target-member-computed-reference-null.js, just with a valid base object.

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For full coverage of the normative PR, do we also need a similar test for super[prop()]?

@rkirsling
Copy link
Member Author

Good point! Updated.

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nice work picking a different name for S11.13.1_A7_T3.js, as well.

rkirsling and others added 2 commits April 12, 2024 11:50
@ptomato
Copy link
Contributor

ptomato commented Apr 12, 2024

The ESMeta test is failing because of a chicken and egg problem: tc39/ecma262#3307 isn't merged into the spec yet. In other such cases recently, I've always merged the test262 PR first.

@ptomato ptomato merged commit 142a6a6 into tc39:main Apr 12, 2024
7 of 8 checks passed
@rkirsling rkirsling deleted the patch-1 branch April 13, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants