test(bindings/js): unfix segfault #517
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
=======================================
Coverage 83.16% 83.16%
=======================================
Files 25 25
Lines 6678 6678
=======================================
Hits 5554 5554
Misses 1071 1071
Partials 53 53 Continue to review full report at Codecov.
|
tdewolff
added a commit
that referenced
this pull request
Jul 11, 2022
tdewolff
added a commit
that referenced
this pull request
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
os.Exit(0)call will terminate the node process completely and return a 0 status, making it seem like the test passed, but that will also prematurely terminate any running program...