Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an enviroment option to disable user self registration #441

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mz0in
Copy link

@mz0in mz0in commented Mar 13, 2024

This will add environment option to disable user self registration , this is a simple method that can be triggered after the first run of the application and the owner or admin register him self and then can make sure that only user with valid invitation link is able to sign in , or he can provide another instance that has the user registration allowed.

This will add a step to disable user sign up , when the env is set to true : DISABLE_SIGNUP=true  , the default is false
@Nainterceptor
Copy link

Hi, I want this feature too.
I think that it's better to pass through config layer (like https://github.com/teableio/teable/blob/develop/apps/nestjs-backend/src/configs/base.config.ts).
And .env example file that you're modifying is related to front part of the app.
Do you want to make changes or can I submit another PR ?

@mz0in
Copy link
Author

mz0in commented Mar 20, 2024

Hi, I want this feature too. I think that it's better to pass through config layer (like develop/apps/nestjs-backend/src/configs/base.config.ts). And .env example file that you're modifying is related to front part of the app. Do you want to make changes or can I submit another PR ?

hello , you can add a new PR , since this PR is not approved yet by the teable team , your approach does the same goal so go on , Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants