Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy path util functions from legacy to harmony #5188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

copy path util functions from legacy to harmony #5188

wants to merge 1 commit into from

Conversation

ocombe
Copy link
Member

@ocombe ocombe commented Dec 27, 2021

No description provided.

@ocombe
Copy link
Member Author

ocombe commented Dec 27, 2021

@GiladShoham I copied all the functions from the path file in legacy, although it seems like only normalizePathToLinux is used in all of our components, should I just remove the other functions ?

@GiladShoham
Copy link
Member

I think the other are used in the legacy. And since we are going to remove it from the legacy and replace it with the package we will probably need it

@GiladShoham
Copy link
Member

@ocombe maybe we should name it something like
path/os-compatibility
Then export all the types as well?
Also, I would remove the getPathRelativeRegardlessCWD from this component. it's not really related. maybe extract it to its own component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiladShoham GiladShoham Awaiting requested review from GiladShoham

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ocombe @GiladShoham