move loader from legacy to harmony #5221
Conversation
ocombe
force-pushed
the
feat/harmony-loader
branch
from
813a169
to
2afa95a
Compare
| @@ -0,0 +1,3 @@ | |||
| import loader from '@teambit/legacy/dist/cli/loader'; | |||
There was a problem hiding this comment.
we need to move the real loader here, we don't allow regular components (which are not aspects) to be dependent on @teambit/legacy
you can by the way just export the loader from another temp workspace, then in this pr only start using it (also in the legacy code)
There was a problem hiding this comment.
we can't do that, because if there are 2 instances of the loader it creates bugs in the cli
There was a problem hiding this comment.
why can't we take the code from src/cli/loader/loader.ts into the loader here
and replace the code in the src/cli/loader/loader.ts to something like
export loader as default from '@teambit/harmony.modules.cli.loader';
And of course, add it to the package.jon once we export
| import loader from './loader'; | ||
|
|
||
| export default loader; |
There was a problem hiding this comment.
let's also make at least a doc file for this
ocombe
force-pushed
the
feat/harmony-loader
branch
from
2afa95a
to
f168f80
Compare
| @@ -0,0 +1,3 @@ | |||
| import loader from '@teambit/legacy/dist/cli/loader'; | |||
There was a problem hiding this comment.
why can't we take the code from src/cli/loader/loader.ts into the loader here
and replace the code in the src/cli/loader/loader.ts to something like
export loader as default from '@teambit/harmony.modules.cli.loader';
And of course, add it to the package.jon once we export
Created a new loader component in harmony. We still re-export the loader from legacy because if there are 2 instances of the loader it creates bugs in the cli, in the long term we should be able to completely move the code to harmony, but for now we need to re-export.