fixed env config renaming

[NitsanCohen770]

Fix

• Update teambit.envs/envs Property: Ensures the teambit.envs/envs prop in bitmap is updated when renaming an environment. This correction handles the property in components using that environment.
• Partial Name Handling: Now effectively manages scenarios where developers might use a partial name. For instance, transforming teambit.react/react-env to just react-env during a rename operation.

Changes

1. New Method in Workspace Aspect:

   • Introduced the replaceEnvForAllComponents method within the Workspace aspect. This method allows for the substitution of an environment for all components reliant on the old environment, returning the IDs of affected components.

2. Updates to Rename Method:

   • Adjustments made to the rename method ensure that it checks if a component is an environment component and then uses the new replaceEnvForAllComponents method.

3. Bit Env Replace Command Update:

   • Extracted the logic from the original Bit env replace command and integrated it into a new method, enhancing its functionality.

4. Refactoring:

   • Logic from the replace env command was extracted and moved to a new method on the workspace aspect. Both the replace and rename methods utilize this.

5. Removed Method:

   • The renameAspectInConfig method, previously used for renaming aspects in component configs, has been removed.

---

Kindly review the changes and share your feedback.

[GiladShoham]

Why this need be!== and not ===
With!== it will replace any env for any component to the new one

[NitsanCohen770]

because it works? 🤣
envConfig.env is the env prop in the config for the currently iterated component in the bitmap.
the sourceId (should change it to the fullSoruceId) is the env we want to change.
So you are right and I have to fix it now 😨 (I was testing it on one component)

Fixed on next commit. Also fixed a case where the source env is specified with a version and it wouldn't detect it.

[GiladShoham]

Instead of try catch you can use
getBitmapEntryIfExist
And instead of doing toStringWithoutVersion
you can pass a second arg to the get like this:

{
  "ignoreVersion": true
}

[NitsanCohen770]

Thanks
Actually, I realized that the sourceId is already a componentId so this whole get entry is just redundant.

[GiladShoham]

how sourceId.toStringWithoutVersion(); becomes full source id?

[NitsanCohen770]

because it is passed as componentId as you can see in the method params:

 async rename(sourceIdStr: string, targetName: string, options: RenameOptions): Promise<RenameDependencyNameResult> {
    if (!isValidIdChunk(targetName)) {
      if (targetName.includes('.'))
        throw new Error(`error: new-name argument "${targetName}" includes a dot.
make sure this argument is the name only, without the scope-name. to change the scope-name, use --scope flag`);
      throw new InvalidName(targetName);
    }
    const sourceId = await this.workspace.resolveComponentId(sourceIdStr);   <-----

[GiladShoham]

ok, I understand, in that case the name of your var is confusing, it's not a full source id, but soruceIdWithoutVersion

[GiladShoham]

ok, I understand, in that case the name of your var is confusing, it's not a full source id, but soruceIdWithoutVersion

[GiladShoham]

The envConfig.env might have a value with a version, in that case, your new check will miss it.

[NitsanCohen770]

This check is for this prop:

 "env": "teambit.react/react-env"
            }

afaik it can't be with the version over there.

I think the issue you are referring to is with the env itself as a prop for example:

"teambit.react/react-env@1.0.6": {},

In that case, this one is resolved here:

  if (aspectIdWithoutVersion === sourceIdWithoutVersion) {