fix: downgrade typescript to fix dynamic import issue #1475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I updated several packages, I also update TypeScript by a few minor versions - it is rare, but this caught a bug with a new TypeScript version. TypeScript 4.9 introduced a change that altered how dynamic imports worked (see attached screenshot for the issue in the changelog for TS 4.9). This change, cause dynamic imports to be transpiled from:
to
When transpiling to a CommonJS module format, which we are doing. This is a problem, because while Webpack tree-shaking can determine asset relevance in the first example, it cannot in the second.
This PR forces the TS resolution to stop at 4.8.4, which removes this change and maintains the prior transpilation of the
Icon
component.