Allow search-as-you-type functionality on boolean search #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've run into this too. Would be great to see this merged. |
nbolender
force-pushed
the
boolean-asyoutype
branch
from
f12cacb
to
7783036
Compare
|
Have you tested this, does it work correctly as expected? |
|
@nticaric I have been using it in production for years. I just upgraded to the latest and synced my fork, and it still works as expected. My only concern about merging it is that I’m not sure if everyone who uses Boolean search wants this functionality. But if you do, you can target this branch to try it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer to use boolean search for as-you-type searching because it gives more concise results, especially when words like 'the' are used. However, as it stands TNTSearch is not able to match partial words when using boolean search.
This PR is a quick patch to enable this functionality. It may need to be revised because I am not incredibly familiar with the code base, but it works for my project so far.