Fixes for JupyterLab 1.0.0

[agoose77]

No description provided.

[agoose77]

Not sure if there were any modified icons by this theme - I just took them from master in theme-dark-extension

[agoose77]

I didn't restore scrollbars.css as I felt this might have been ommitted for a reason. I just returned the basic scrollbar theming.

[telamonian]

Thanks for helping me get this up to date!

Don't need scrollbars.css, since the contents of that were already pushed upstream to jlab itself.

I looked over your changes, and the only thing that caught my eye is that there's probably still a bunch of now-unused icons sitting around (if I'm interpreting the changes you made to style/urls.css correctly). There's no custom icons in this theme, so you can just nuke style/icons and style/images and replace them with the latest versions from @jupyterlab/theme-dark-extension.

Other than that, I think it looks ready to pull. I also need to sort out why the CI is failing, but that probably has nothing to do with this PR.

[agoose77]

Hey no problem, it's a great extension and it was about time I contributed more than GitHub Issues.

Yeah, if you've just exported the JLab icons, I'll overwrite them from master and update urls respectively.
It looks like Travis failed because it hit the token page, but I haven't really looked into it.

[agoose77]

Updated images.

[telamonian]

Okay, everything looks great, and I tested and can confirm it works with the latest Jlab release (1.0.4). Thanks for all your work, @agoose77!

[telamonian]

I'll pull this and then do an npm release

[telamonian]

Hmm, I guess I still have to rebase and/or merge with master (they've drifted apart). But I think I'll save that for a future release.

[agoose77]

No worries, I'd have felt them same if someone had snuck in an explicitly rejected change. Thanks for the help!

…

On Wed, 31 Jul 2019, 10:33 Max Klein, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In style/variables.css <#5 (comment)> : > @@ -179,9 +179,9 @@ all of MD as it is not optimized for dense, information rich UIs. * Code font variables are used for typography of code and other monospaces content. */ - --jp-code-font-size: 15px; - --jp-code-line-height: 1.3077; /* 17px for 15px base */ - --jp-code-padding: 0.385em; /* 5px for 15px base */ + --jp-code-font-size: 14px; + --jp-code-line-height: 1.214; /* 17px for 15px base */ + --jp-code-padding: 0.357em; /* 5px for 15px base */ That's okay. The other day, for lack of a missing colon I accidentally force pushed an empty branch to someone else's long-running PR. Sorry to have been snippy. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=AAJQZHPZVHDF3V5DUDPB4OTQCFL7LA5CNFSM4H62FJO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCADPSKA#discussion_r309125354>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJQZHNBJQTW7X446AM7Y7TQCFL7LANCNFSM4H62FJOQ> .