-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spreadsheet Budgeting app #4274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoomFX
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check the following:
- The Login page does not look very good when you change the window dimensions (height/width). It does not look as the suggested design for "962x601" and "360x800"
- The "Simple Event" text/logo is not vertically centered in the Header.
- On the "Event Budget" page:
- the "Event Budget" text/header and the background behind it does not seem to be properly positioned when changing the window width/height. It is caused by this code, it seems that it shouldn't be there at all.
- it is a bit strange that there is a separate DIV, with
position: absolute;
andbackground-position: -15vw 4.8vw;
, that holds the background image. Usually such backgrounds are applied to thebody
or in this case it might be the.container
element and then leave the browser to take care of its placement on the different resolutions. - the page markup is also a big strange. Visually, the Header is first and then comes the "Event Budget" header. However in the markup it is ordered differently (screenshot).
- On the "Get Tickets" and "Call for Speakers" pages:
- the "Get Tickets" and "Apply to Speak at Conference" text/headers and the background behind them do not seem to be properly positioned when changing the window width/height. It is caused by some elements that have a fixed width while (on smaller screens) they should be
width: 100%;
- the page markup here is strange as well, same as the "Event Budget" page above.
- the "Get Tickets" and "Apply to Speak at Conference" text/headers and the background behind them do not seem to be properly positioned when changing the window width/height. It is caused by some elements that have a fixed width while (on smaller screens) they should be
- Native HTML elements should not be styled like that. Give the particular element a dedicated class and write the styles scoped to this particular class.
mbechev
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference and design - private thread