Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update licensegen to output the current year for new files #5852

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Waldeedle
Copy link

What changed?

Why?

To resolve #5553, users currently have to manually update the year and reviewers need to keep that context in mind when its a fairly straightforward automation.

How did you test it?

created a new .go file without a header and ran the make copyright command

Potential risks

Nothing

Documentation

Not applicable to the enhancement

Is hotfix candidate?

No

@Waldeedle Waldeedle requested a review from a team as a code owner May 5, 2024 17:51
@CLAassistant
Copy link

CLAassistant commented May 5, 2024

CLA assistant check
All committers have signed the CLA.

@Waldeedle
Copy link
Author

I decided to also add a linting step as part of the pipeline to ensure that a missing license is automatically flagged for new go files.

@Waldeedle
Copy link
Author

Tested the linting with this example PR: Waldeedle#2
First I didn't have any licensing information, then I updated the licensing information to be the wrong year.
The linting step caught both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update license check script to verify current year is used in new files
2 participants