Remove state machine task type from the outbound queue key type #5895
Conversation
| key.NamespaceID, | ||
| key.Destination, | ||
| ), | ||
| }, | ||
| ) | ||
| }, | ||
| ) | ||
| grouper := queues.GrouperStateMachineNamespaceIDAndDestination{} | ||
| grouper := queues.GrouperNamespaceIDAndDestination{} |
There was a problem hiding this comment.
I'm debating whether we also want to group tasks by this predicate.
Right now there are 3 task types on this queue:
- callbacks
- nexus start operation
- nexus cancel operation
We want 2 and 3 to be grouped together and 1 to never be grouped with them.
Today coincidentally your change achieves want we want works because the destinations for callbacks and nexus operations are not going to overlap.
When we add a fourth task type, we'll want the able to control the grouping.
So I think we actually want to instead of removing the task type dimension, replace it with something that gives us extra control. That'll be a bit more difficult to set up because you'll want the grouping to be set where the task is defined, e.g. add it here
temporal/service/history/hsm/tasks.go
Line 87 in 794eccd
If you want to put in the effort for that, go ahead but otherwise leave the code that's in main.
What changed?
Remove state machine task type from the outbound queue key type
Why?
State machine task type is not being used, and dynamic configs don't have task type, so caching with state machine task type will result is unexpected results.
How did you test it?
Added unit tests for the grouper.
Potential risks
Documentation
Is hotfix candidate?