Fix TestDeleteWorkflowExecution_JustTerminatedWorkflow flaky test #5913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
fix/flaky-running-with-terminate
branch
from
6633050
to
85d3ed0
Compare
alexshtin
changed the title
alexshtin
commented
May 14, 2024
tdeebswihart
approved these changes
May 14, 2024
yycptt
approved these changes
May 14, 2024
ychebotarev
pushed a commit
to ychebotarev/temporal
that referenced
this pull request
May 16, 2024
…mporalio#5913) ## What changed? <!-- Describe what has changed in this PR --> Fix `TestDeleteWorkflowExecution_JustTerminatedWorkflow` (former `Test_DeleteWorkflowExecution_RunningWithTerminate`) flaky test. ## Why? <!-- Tell your future self why have you made these changes --> Test fails from time to time w/o clear reason. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix
TestDeleteWorkflowExecution_JustTerminatedWorkflow(formerTest_DeleteWorkflowExecution_RunningWithTerminate) flaky test.Why?
Test fails from time to time w/o clear reason.
How did you test it?
Existing tests.