Update Flightdeck to Alpine 3.16 and PHP 8.1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Important for rebasing on Alpine 3.16, as the newer ansible version is bugged. - ansible/ansible#78491
- Needed for .net tests, otherwise not super important at the moment.
- Remove Global Drush install, no longer recommended and broken. - See: drush-ops/drush#5156 - Adds path for wpcli to be owned by Apache (this errors if not done) - Removes php-pecl-mcrypt, the library is deprecated and the Alpine package has not been updated to PHP 8.1.
- Current Alpine 3.16 package has PHP 8 hardcoded.
- This breaks Drush usage, so we override it here.
- Technically the latest PHP 8 is installed as Composer depends on it,
but none of the modules are installed, and PHP 8.1 takes PATH precedence.
- Allows calling drush instead of ./vendor/bin/drush - Also allows using drush outside of the Drupal installation directory.
- Global drush is no longer supported, this removes the configuration key for it.
- Alpine linux puts PHP 8.1 in folders prefixed with php81, this updates all the PHP call paths to match.
|
This completely passes the AHS test, minus a small mountain of PHP deprecation errors that were expected. The only breaking changes from flightdeck-web-8.0 is the following:
|
madeline-holland
pushed a commit
that referenced
this pull request
Oct 3, 2022
Add support for a defined entrypoint into web container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpine 3.15 doesn't have PHP 8.1 packages, requiring an update to Alpine 3.16.