Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to add env tests to 2.x #264

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

trying to add env tests to 2.x #264

wants to merge 3 commits into from

Conversation

luceos
Copy link
Contributor

@luceos luceos commented Sep 20, 2022

No description provided.

@ArlonAntonius
Copy link
Member

Do not merge this please, is actually a breaking change

@luceos
Copy link
Contributor Author

luceos commented Sep 21, 2022

What exactly is breaking about this PR please?

@ArlonAntonius
Copy link
Member

Right now it prevents geidentifying when a tenant has already been identified.
This is intended behaviour, not a bug. It could have automatic unintended effects for people's applications, reidentifying while they really do not want it to.

@luceos
Copy link
Contributor Author

luceos commented Sep 22, 2022

The first argument false causes tenancy to not refresh the tenant. If the tenant is already identified, it will return the existing Tenant not a new one. This is not a breaking change.

See:

public function identifyTenant(bool $refresh = false, string $contract = null): ?Tenant
{
if (!$this->identified || $refresh) {
$resolver = $this->tenantResolver();
$this->setTenant($resolver($contract));
}
return $this->getTenant();
}

Copy link
Member

@ArlonAntonius ArlonAntonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luceos is right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants