Bug: Make sure the tenant connection is not used for moving tables #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #265 +/- ##
============================================
- Coverage 98.97% 98.84% -0.13%
Complexity 290 290
============================================
Files 98 98
Lines 777 778 +1
============================================
Hits 769 769
- Misses 8 9 +1 |
luceos
reviewed
Nov 4, 2022
Comment on lines
+139
to
+147
| $tempConnectionName = Str::random(16); | ||
|
|
||
| /** @var ResolvesConnections $resolver */ | ||
| $resolver = resolve(ResolvesConnections::class); | ||
| $resolver($tempTenant, Tenancy::getTenantConnectionName()); | ||
| $resolver($tempTenant, $tempConnectionName); | ||
|
|
||
| $tables = Tenancy::getTenantConnection()->getDoctrineSchemaManager()->listTableNames(); | ||
| $tables = DB::connection($tempConnectionName)->getDoctrineSchemaManager()->listTableNames(); | ||
|
|
||
| $resolver(null, Tenancy::getTenantConnectionName()); | ||
| $resolver(null, $tempConnectionName); |
There was a problem hiding this comment.
Can we please simplify this variable into $connection? It is obvious with the Str::random that this concerns a random connection name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239
Short explanation:
In order to move the tables of the tenant to the right database (if the database was updated), we would instantiate a temporary connection on the specified TenantConnectionName. This would override the current tenant connection. Then we would empty that connection as we want to make sure we do not leave the connection open as it would form a security risk. Resulting in there not being a Tenant Connection anymore.
This fix simply uses a completely random connection name.