Allow users to specify the old database themselves using current default logic #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #267 +/- ##
=========================================
Coverage 98.97% 98.97%
- Complexity 290 291 +1
=========================================
Files 98 98
Lines 777 779 +2
=========================================
+ Hits 769 771 +2
Misses 8 8 |
luceos
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
I feel the same struggle with the proposed code as you do. But no matter how I look at it, there doesn't seem a sweeter alternative without going full Monty with some complex implementation where state is carried over outside into event listeners and back into the database mutation logic.
I am okay with this implementation, but yes this is a breaking change and thus needs to be documented and requires at least a minor tag..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
This is a possible solution, but I'm not completely sure yet if this is the best solution.
It's sort of a breaking change; if people have custom logic and have not specified
oldDatabase, but have specifiedoldUsername, than this is becoming an issue.