Update to markdown links #9384

samricotta · 2022-09-07T09:30:28Z

This resolves issue #9181 in ensuring all of the markdown links work so that the linter passes during the CI tests.

There are still a few that will need to be updated, which I couldn't find replacements for.

https://docs.google.com/document/d/11ZhMsCj3y7zIZz4udO9l25xqb0kl7gmWqNpGVRzOeyY/edit - here
https://www.zurich.ibm.com/~cca/papers/sieve.pdf - here

If someone could help out with the above ^^ that would be great

sergio-mena · 2022-09-07T12:08:01Z

https://www.zurich.ibm.com/~cca/papers/sieve.pdf

This link seems to point to that paper.

sergio-mena

Thanks for this Sam!

sergio-mena · 2022-09-07T12:27:25Z

spec/abci/abci.md

@@ -0,0 +1,776 @@
+<!-- markdown-link-check-disable -->


Please remove this file. It was deleted by Jasmina's #9288

sergio-mena · 2022-09-07T12:28:53Z

spec/p2p/messages/consensus.md

@@ -144,6 +144,6 @@ Message is a [`oneof` protobuf type](https://developers.google.com/protocol-buff
 | proposal_pol    | [ProposalPOL](#proposalpol)     |                                        | 4            |
 | block_part      | [BlockPart](#blockpart)         |                                        | 5            |
 | vote            | [Vote](#vote)                   |                                        | 6            |
-| received_vote       | [ReceivedVote](#ReceivedVote)           |                                        | 7            |
+| received_vote       | [ReceivedVote](#receivedvote)           |                                        | 7            |


You might want to fix the spacing here

sergio-mena · 2022-09-07T12:29:21Z

spec/p2p/messages/pex.md

@@ -29,7 +29,7 @@ PexResponse is an list of net addresses provided to a peer to dial.

 | Name  | Type                               | Description                              | Field Number |
 |-------|------------------------------------|------------------------------------------|--------------|
-| addresses | repeated [PexAddress](#PexAddress) | List of peer addresses available to dial | 1            |
+| addresses | repeated [PexAddress](#pexaddress) | List of peer addresses available to dial | 1            |


Please fix spacing of tables in the changes to this file

sergio-mena · 2022-09-07T12:31:41Z

https://docs.google.com/document/d/11ZhMsCj3y7zIZz4udO9l25xqb0kl7gmWqNpGVRzOeyY

This is a "fork accountability report". I didn't find a substitute link for this. Maybe @josef-widder, when he's back for leave could find a place we could point to.

samricotta · 2022-09-07T13:15:22Z

@sergio-mena in that case should I disable this link for now and when we find a replacement link?

sergio-mena · 2022-09-07T16:28:37Z

should I disable this link for now and when we find a replacement link?

I agree with that

samricotta · 2022-09-07T19:57:21Z

@sergio-mena one last link! I have disabled it for now https://github.com/tendermint/tendermint/blob/main/CHANGELOG.md?plain=1#L1227 but this is another one that I cannot find the docs for

thanethomson · 2022-09-07T20:28:56Z

DOCKER/README.md

+<!-- markdown-link-check-disable-next-line -->
 Respective versioned files can be found <https://raw.githubusercontent.com/tendermint/tendermint/vX.XX.XX/DOCKER/Dockerfile> (replace the Xs with the version number).


This shouldn't really be a link.

Suggested change



Respective versioned files can be found <https://raw.githubusercontent.com/tendermint/tendermint/vX.XX.XX/DOCKER/Dockerfile> (replace the Xs with the version number).

Respective versioned files can be found at `https://raw.githubusercontent.com/tendermint/tendermint/vX.XX.XX/DOCKER/Dockerfile` (replace the Xs with the version number).

thanethomson · 2022-09-07T20:31:09Z

RELEASES.md

@@ -45,7 +45,7 @@ the 0.38.x line.
 1. Start on `main`

 2. Ensure that there is a [branch protection
-   rule](https://github.com/tendermint/tendermint/settings/branches) for the
+   rule](https://github.com/tendermint/tendermint/branches) for the


Technically the original link was correct, but it may be showing up as a 404 because you need admin privileges to access it. Let's rather substitute with GitHub's documentation here.

Suggested change

rule](https://github.com/tendermint/tendermint/branches) for the

rule](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule) for the

thanethomson · 2022-09-07T20:31:47Z

consensus/README.md

@@ -1,3 +1,3 @@
 # Consensus 

-See the [consensus spec](https://github.com/tendermint/tendermint/tree/main/spec/consensus) and the [reactor consensus spec](https://github.com/tendermint/tendermint/tree/main/spec/reactors/consensus) for more information.
+See the [consensus spec](https://github.com/tendermint/tendermint/tree/main/spec/consensus)


Suggested change

See the [consensus spec](https://github.com/tendermint/tendermint/tree/main/spec/consensus)

See the [consensus spec](https://github.com/tendermint/tendermint/tree/main/spec/consensus) for more information.

sergio-mena · 2022-09-07T21:00:47Z

@sergio-mena one last link!

Will this do? 😀
https://docs.tendermint.com/v0.34/tutorials/java.html

cason · 2022-10-25T18:46:30Z

RELEASES.md

@@ -45,7 +45,7 @@ the 0.38.x line.
 1. Start on `main`

 2. Ensure that there is a [branch protection
-   rule](https://github.com/tendermint/tendermint/settings/branches) for the
+   rule](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule) for the


@samricotta this is the line and link with the unreachable link....

first correction of markdown links

6020f86

samricotta added the S:wip Work in progress (prevents stalebot from automatically closing) label Sep 7, 2022

samricotta requested a review from ebuchman as a code owner September 7, 2022 09:30

samricotta requested review from a team September 7, 2022 09:30

samricotta and others added 2 commits September 7, 2022 11:31

Merge branch 'main' into markdown-links

19bb701

config: fix broken test (#9309)

bee9af6

samricotta force-pushed the markdown-links branch from 72a7705 to 14c716a Compare September 7, 2022 10:05

Update block.proto

2135336

samricotta force-pushed the markdown-links branch from deefa14 to 2135336 Compare September 7, 2022 11:32

samricotta and others added 2 commits September 7, 2022 14:25

paper link

4477195

Merge branch 'main' into markdown-links

a1578a1

sergio-mena approved these changes Sep 7, 2022

View reviewed changes

review updates

8e8ef09

samricotta force-pushed the markdown-links branch from 75946b1 to 8e8ef09 Compare September 7, 2022 19:55

thanethomson reviewed Sep 7, 2022

View reviewed changes

samricotta and others added 2 commits September 8, 2022 09:57

Review updates

9b18dc0

Merge branch 'main' into markdown-links

500575b

samricotta merged commit 5013bc3 into main Sep 8, 2022

samricotta deleted the markdown-links branch September 8, 2022 08:31

cason reviewed Oct 25, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to markdown links #9384

Update to markdown links #9384

samricotta commented Sep 7, 2022 •

edited

sergio-mena commented Sep 7, 2022

sergio-mena left a comment

sergio-mena Sep 7, 2022

sergio-mena Sep 7, 2022

sergio-mena Sep 7, 2022

sergio-mena commented Sep 7, 2022

samricotta commented Sep 7, 2022

sergio-mena commented Sep 7, 2022

samricotta commented Sep 7, 2022

thanethomson Sep 7, 2022

samricotta Sep 8, 2022

thanethomson Sep 7, 2022

thanethomson Sep 7, 2022

sergio-mena commented Sep 7, 2022

cason Oct 25, 2022

		<!-- markdown-link-check-disable-next-line -->
		Respective versioned files can be found <https://raw.githubusercontent.com/tendermint/tendermint/vX.XX.XX/DOCKER/Dockerfile> (replace the Xs with the version number).

	rule](https://github.com/tendermint/tendermint/branches) for the
	rule](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule) for the

	See the [consensus spec](https://github.com/tendermint/tendermint/tree/main/spec/consensus)
	See the [consensus spec](https://github.com/tendermint/tendermint/tree/main/spec/consensus) for more information.

Update to markdown links #9384

Update to markdown links #9384

Conversation

samricotta commented Sep 7, 2022 • edited

sergio-mena commented Sep 7, 2022

sergio-mena left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergio-mena commented Sep 7, 2022

samricotta commented Sep 7, 2022

sergio-mena commented Sep 7, 2022

samricotta commented Sep 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergio-mena commented Sep 7, 2022

Choose a reason for hiding this comment

samricotta commented Sep 7, 2022 •

edited