Flip --incompatible_enforce_config_setting_visibility in .bazelrc to prevent regression #58832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
force-pushed
the
incompatible_flags
branch
from
0add7fa
to
b4edfd4
Compare
|
Looks like tf_runtime needs to be fixed first. |
|
learning-to-play
approved these changes
Dec 10, 2022
google-ml-butler
bot
added
kokoro:force-run
meteorcloudy
changed the title
meteorcloudy
added a commit
to meteorcloudy/runtime
that referenced
this pull request
Dec 12, 2022
copybara-service bot
pushed a commit
to tensorflow/runtime
that referenced
this pull request
Dec 12, 2022
Related tensorflow/tensorflow#58832 Fixes #113 PiperOrigin-RevId: 494773403
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Dec 13, 2022
…bazelrc to prevent regression Imported from GitHub PR tensorflow/tensorflow#58832 Related: bazelbuild/bazel#12932 and bazelbuild/bazel#12933 Copybara import of the project: -- b4edfd47bd9a0c0363a9feb1eb1b48d067e4644e by Yun Peng <pcloudy@google.com>: Flip two incompatible flags in .bazelrc to prevent regression -- c33c0dd6e5744393fe2b1909efc91dc19bd6dda1 by Yun Peng <pcloudy@google.com>: Add visibility to more targets -- 34d1bfe1564f0905993c26a891f2385b83480e3d by Yun Peng <pcloudy@google.com>: --incompatible_config_setting_private_default_visibility cannot be flipped yet Merging this change closes #58832 PiperOrigin-RevId: 494895621
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Dec 13, 2022
…bazelrc to prevent regression Imported from GitHub PR tensorflow/tensorflow#58832 Related: bazelbuild/bazel#12932 and bazelbuild/bazel#12933 Copybara import of the project: -- b4edfd47bd9a0c0363a9feb1eb1b48d067e4644e by Yun Peng <pcloudy@google.com>: Flip two incompatible flags in .bazelrc to prevent regression -- c33c0dd6e5744393fe2b1909efc91dc19bd6dda1 by Yun Peng <pcloudy@google.com>: Add visibility to more targets -- 34d1bfe1564f0905993c26a891f2385b83480e3d by Yun Peng <pcloudy@google.com>: --incompatible_config_setting_private_default_visibility cannot be flipped yet Merging this change closes #58832 PiperOrigin-RevId: 494895621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: bazelbuild/bazel#12932 and bazelbuild/bazel#12933