[xla:ffi] Unify external and internal user data registration and use i64 type ids #67401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_632841384
branch
2 times, most recently
from
b01a610
to
27b30ae
Compare
…i64 type ids - treat external and internal user data uniformly as an opaque pointer + optional deleter - use the same i64 TypeId for internal and external types to avoid expensive string comparison on a hot path PiperOrigin-RevId: 633234788
copybara-service
bot
force-pushed
the
exported_pr_632841384
branch
from
27b30ae
to
ad6690b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xla:ffi] Unify external and internal user data registration and use i64 type ids