Support IP-in-subnet queries in lookup tables #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavam
force-pushed
the
topic/lookup-table-subnet-keys
branch
from
2c60c5a
to
a8947e2
Compare
mavam
added
improvement
mavam
force-pushed
the
topic/lookup-table-subnet-keys
branch
from
ed03587
to
797376a
Compare
|
@mavam Out of curiosity: Did you see https://github.com/zeek/pysubnettree before and consider using the patricia trie from it? |
|
Yep, this is exactly the implementation I'm using now. |
mavam
force-pushed
the
topic/lookup-table-subnet-keys
branch
3 times, most recently
from
2de4566
to
b1c2b6c
Compare
mavam
commented
May 27, 2024
mavam
commented
May 27, 2024
mavam
commented
May 27, 2024
This code comes from https://github.com/sikol/patricia as of commit 1a389b34a03c9069886e4ff0b7782e84cb67d25f. We only applied clang-format so that our CI is happy.
The same key length comparison also takes place within prefix_compare().
mavam
force-pushed
the
topic/lookup-table-subnet-keys
branch
from
461d573
to
cbc3cbe
Compare
mavam
force-pushed
the
topic/lookup-table-subnet-keys
branch
from
097654a
to
f369aa5
Compare
mavam
force-pushed
the
topic/lookup-table-subnet-keys
branch
from
f369aa5
to
cdf6b01
Compare
mavam
force-pushed
the
topic/lookup-table-subnet-keys
branch
from
66cb39b
to
f98dca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances lookup tables when their key type is a
subnetvalue. In this case, it is now possible to probe the lookup table with a value of typeipand perform a prefix match on all contained subnets.