Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement strides for the slice operator #4216

Merged
merged 7 commits into from
May 17, 2024
Merged

Implement strides for the slice operator #4216

merged 7 commits into from
May 17, 2024

Conversation

dominiklohmann
Copy link
Member

This adds an option to add strides in the slice operator, and adds a reverse as a shorthand notation for slice ::-1.

@dominiklohmann dominiklohmann added feature New functionality operator Source, transformation, and sink labels May 13, 2024
@dominiklohmann dominiklohmann requested a review from mavam May 13, 2024 15:19
@dominiklohmann dominiklohmann force-pushed the topic/slice-with-stride branch 2 times, most recently from 5d352e1 to 24229af Compare May 13, 2024 15:23
mavam
mavam reviewed May 13, 2024
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check the implementation, but the scaffolding makes sense.

web/docs/operators/slice.md Outdated Show resolved Hide resolved
web/docs/operators/slice.md Show resolved Hide resolved
web/docs/operators/reverse.md Outdated Show resolved Hide resolved
Base automatically changed from topic/slice-syntax to main May 14, 2024 13:36
jachris
jachris approved these changes May 14, 2024
View reviewed changes
libtenzir/src/tql/parser.cpp Outdated Show resolved Hide resolved
@dominiklohmann
Implement strides for the slice operator
83aca9a 
This adds an option to add strides in the `slice` operator, and adds a
`reverse` as a shorthand notation for `slice ::-1`.
@dominiklohmann
Improve slice and reverse docs
45e81d6
@dominiklohmann
Fix ambiguity between slice and IPv6 literals
9fb1d14
@dominiklohmann
Fix error message
79818a1
@dominiklohmann
Fix the Docker build (2nd take)
4599ca9
@dominiklohmann
Pin Arrow to 15.0.2 in the Dockerfile
e4b71c8 
The 16.1.0 causes too many issues, let's unpin this only once Arrow 17
or 16.2 are out.
@dominiklohmann dominiklohmann merged commit f30c199 into main May 17, 2024
53 checks passed
@dominiklohmann dominiklohmann deleted the topic/slice-with-stride branch May 17, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam left review comments

@jachris jachris jachris approved these changes

Assignees
No one assigned
Labels
feature New functionality operator Source, transformation, and sink
Projects
None yet
Milestone
No milestone
3 participants
@dominiklohmann @mavam @jachris