Prom client in mock prom metrics #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
force-pushed
the
prom-client-in-mock-prom-metrics
branch
from
11af198
to
29c9d02
Compare
bump: (patch) @terascope/job-components@0.74.2, terafoundation@0.63.2
busma13
force-pushed
the
prom-client-in-mock-prom-metrics
branch
from
29c9d02
to
41f80f1
Compare
godber
approved these changes
May 15, 2024
| @@ -1113,9 +1113,7 @@ export class ExecutionController { | |||
| * @link https://terascope.github.io/teraslice/docs/development/k8s#prometheus-metrics-api | |||
| */ | |||
| async setupPromMetrics() { | |||
| this.logger.info(`adding ${this.context.assignment} prom metrics...`); | |||
There was a problem hiding this comment.
You don't need to add it back right now but I think logging, at the info level, that prom metrics are enabled (once at "init" or "setup") makes sense.
Generally speaking a log for every optional feature that is "enabled" is useful, if it occurs ONCE per run.
There was a problem hiding this comment.
I must have deleted that accidentally. I'll add it back in.
| @@ -150,7 +150,8 @@ export class ClusterMaster { | |||
| tf_prom_metrics_enabled: terafoundation.prom_metrics_enabled, | |||
| tf_prom_metrics_port: terafoundation.prom_metrics_port, | |||
| logger: this.logger, | |||
| assignment: 'cluster_master' | |||
| assignment: 'master', | |||
| prefix: 'teraslice_' | |||
There was a problem hiding this comment.
These are the "API" changes that are relevant to document in the CHANGELOG.
godber
pushed a commit
that referenced
this pull request
May 17, 2024
This PR fixes a bug introduced in #3613, where the worker's `slicesProcessed` promMetric `collect()` function would throw an error when metrics were scraped, causing the pod to crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
teraslice_prefix topromMetrics.init()for master so all metric names match what was interaslice-exporterpackage.mockPrommetricsto useprom-client. This allowscollect()functions to be used inTestContext.