Fix bug relating to use of relative paths in CACHE #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CACHE object is used to remember whether a path was a directory or not across glob() calls. Previously, this cache was keyed by the relative path of the file (i.e. the basename). This can result in missing results (not descending into a directory because it was incorrectly thought to be a file), or an exception (attempting to descend into a file because it was thought to be a directory). Now, the CACHE object is instead keyed by the full path, instead of the relative path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CACHEobject is used to remember whether a path was a directory or not acrossglob()calls. Previously, this cache was keyed by the relative path of the file (i.e. the basename).This can result in missing results (not descending into a directory because it was incorrectly thought to be a file), or an exception (attempting to descend into a file because it was thought to be a directory).
Now, the
CACHEobject is instead keyed by the full path, instead of the relative path.