New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support FORCE_COLOR
and detect tty
#25
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 77 106 +29
=========================================
+ Hits 77 106 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@hugovk I'm trying to compare |
I don't know of a Doing some quick searches across GitHub repos:
|
(Sorry we're diverging about the original PR)
More than a website, it would be some kind of spec, so |
There's a good summary of
I made a summary of some Python libraries last year at pypa/pip#10909 (comment), the majority by downloads check for presence of any value. I use And I'd suggest following the
So something like (changes in italics):
|
Thank you for this thorough investigation! |
Fixes #2.
In the absence of special env vars, colour is enabled used when we're attached to a tty, that isn't a dumb terminal.
Normally we don't want to use colour for non-tty, like when piping output.
But GitHub Actions is also not a tty and supports colour, so add support for
FORCE_COLOR
, which follows similar runes toNO_COLOR
, to allow colour logging.