Fixed undefined exception in log message (#294)

terminal42 · Dec 11, 2023 · 73f3c43 · 73f3c43
1 parent 5c1027e
commit 73f3c43
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/library/NotificationCenter/Gateway/Email.php b/library/NotificationCenter/Gateway/Email.php
@@ -160,11 +160,13 @@ public function sendDraft(EmailMessageDraft $objDraft)
         try {
             $blnSent = $objEmail->sendTo($objDraft->getRecipientEmails());
         } catch (\Exception $e) {
-            $blnSent = false;
+            \System::log(sprintf('Could not send email to "%s" for message ID %s: %s', implode(', ', $objDraft->getRecipientEmails()), $objDraft->getMessage()->id, $e->getMessage()), __METHOD__, TL_ERROR);
+
+            return false;
         }
 
         if (!$blnSent) {
-            \System::log(sprintf('Could not send email to "%s" for message ID %s: %s', implode(', ', $objDraft->getRecipientEmails()), $objDraft->getMessage()->id, $e->getMessage()), __METHOD__, TL_ERROR);
+            \System::log(sprintf('Could not send email to "%s" for message ID %s', implode(', ', $objDraft->getRecipientEmails()), $objDraft->getMessage()->id), __METHOD__, TL_ERROR);
         }
 
         return $blnSent;