Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added email gateway migration #328

Merged
merged 1 commit into from
May 6, 2024
Merged

Added email gateway migration #328

merged 1 commit into from
May 6, 2024

Conversation

aschempp
Copy link
Member

@aschempp aschempp commented May 6, 2024

Fixes #327

@Toflar Toflar merged commit f1de9c6 into main May 6, 2024
8 checks passed
@Toflar Toflar deleted the fix/email-gateway branch May 6, 2024 08:15

public function shouldRun(): bool
{
return $this->connection->fetchOne("SELECT COUNT(*) FROM tl_nc_gateway WHERE type='email'") > 0;
Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail when installing NC for the first time?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aschempp that's probably true, will you create another PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fritzmg, fixed in ba534a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No notification-type set ("Unbekannte Option") in Gateway after update to 2.0
3 participants