nodejs: Bump to 16.x

[thunder-coding]

No description provided.

[thunder-coding]

So, let me first explain what changes I have made here and why since this PR is gonna be large

This comment contains problems faced while building node 16.6.1

1. The patches have been shamelessly stolen from suhan-paradkar#8

2. About assembly errors for i868 and arm

This is a known upstream issue about the nodejs toolchain suicidally passing -m32 for host builds of nodejs when cross compiling for 32 bit. See nodejs/node#39736

This needs some special attention

This has been fixed by a temporary patch. x64/push_registers_asm.cc has been patched in a way:

#if defined(V8_TARGET_ARCH_ARM64) || defined(V8_TARGET_ARCH_X86_64)
//original content of the file
#else
// Content of ia32 ASM registers.cc
#endif

This ensures that both cross compile and host builds work. This patch should be removed as soon as upstream fixes it.

3. The toolchain tries to use shared libraries which are passed to configure.py but doesn't pass appropriate linker flags which are fixed by hardcoding host linker to have those linker flags. Luckily it doesn't use the shared libraries compiled for Android.

4. x86_64 builds are broken as in Cross compile node v14.x or v.15.x for android x86_64 nodejs/node#36287 (comment) This should be fixed by some patches in node.gyp as in the comment. This needs to be done properly

The lines in strikes have been fixed and need no attention

[thunder-coding]

Problems faced while building node 16.9.1

1. arpa_nameser.h include: The GYP files somehow didn't add deps/cares/src/lib as include path

2. libuv didn't compile with epoll.c. This patch needs to be also sent upstream

3. ia32(i686) builds fail with undefined reference to functions defined in <atomic>. For mkcodecache this was fixed by adding -latomic, but for node_mksnapshot, this doesn't fix it.
This was fixed by passing proper -u flags to clang as stated in Grimler's comment below

Besides these problems, problems with node 16.6.1 were also persistent without patches

[thunder-coding]

@xeffyr, I got it working for aarch64 and arm. And I tested the binaries and they worked. And only i686 is failing with undefined references for functions declared in <atomic>, I even added a -latomic flag but it didn't work. And some weird thing is that it shows these errors in a file while doesn't even use any of the methods declared in <atomic>. I need your help with this so that nodejs 16 can be available on Termux as soon as possible

[Grimler91]

Flag order could matter (see #3092). Try if patching histograp.gyp, adding 'ldflags': [ '-latomic' ], (or similar) there instead works, and else maybe -u __atomic_fetch_add_8 -u __atomic_load_8 -u __atomic_compare_exchange_8 -latomic as suggested in the other issue

[thunder-coding]

This PR is now ready to merge. The previous CI passed 🥳. I have also declared myself as a maintainer for this package so that this package stays updated