Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't use var.(in|e)gress_ipv6_cidr_blocks on security group sourced (in|e)gress #148

Merged
merged 3 commits into from Apr 16, 2020
Merged

fix: Don't use var.(in|e)gress_ipv6_cidr_blocks on security group sourced (in|e)gress #148

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2c4f14
Don't use var.ingress_ipv6_cidr_blocks on security group sourced ingress
michaelaw320 Nov 26, 2019
9d2b05c
Remove the default value placeholder for ipv6_cidr_blocks, also don't…
michaelaw320 Nov 27, 2019
f29f4d0
Merge branch 'master' into master
antonbabenko Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions main.tf
View file
Open in desktop
Expand Up @@ -97,7 +97,6 @@ resource "aws_security_group_rule" "ingress_with_source_security_group_id" {
type = "ingress"

source_security_group_id = var.ingress_with_source_security_group_id[count.index]["source_security_group_id"]
ipv6_cidr_blocks = var.ingress_ipv6_cidr_blocks
prefix_list_ids = var.ingress_prefix_list_ids
description = lookup(
var.ingress_with_source_security_group_id[count.index],
Expand Down Expand Up @@ -142,7 +141,6 @@ resource "aws_security_group_rule" "computed_ingress_with_source_security_group_
type = "ingress"

source_security_group_id = var.computed_ingress_with_source_security_group_id[count.index]["source_security_group_id"]
ipv6_cidr_blocks = var.ingress_ipv6_cidr_blocks
prefix_list_ids = var.ingress_prefix_list_ids
description = lookup(
var.computed_ingress_with_source_security_group_id[count.index],
Expand Down Expand Up @@ -367,7 +365,6 @@ resource "aws_security_group_rule" "ingress_with_self" {
type = "ingress"

self = lookup(var.ingress_with_self[count.index], "self", true)
ipv6_cidr_blocks = var.ingress_ipv6_cidr_blocks
prefix_list_ids = var.ingress_prefix_list_ids
description = lookup(
var.ingress_with_self[count.index],
Expand Down Expand Up @@ -400,7 +397,6 @@ resource "aws_security_group_rule" "computed_ingress_with_self" {
type = "ingress"

self = lookup(var.computed_ingress_with_self[count.index], "self", true)
ipv6_cidr_blocks = var.ingress_ipv6_cidr_blocks
prefix_list_ids = var.ingress_prefix_list_ids
description = lookup(
var.computed_ingress_with_self[count.index],
Expand Down Expand Up @@ -477,7 +473,6 @@ resource "aws_security_group_rule" "egress_with_source_security_group_id" {
type = "egress"

source_security_group_id = var.egress_with_source_security_group_id[count.index]["source_security_group_id"]
ipv6_cidr_blocks = var.egress_ipv6_cidr_blocks
prefix_list_ids = var.egress_prefix_list_ids
description = lookup(
var.egress_with_source_security_group_id[count.index],
Expand Down Expand Up @@ -522,7 +517,6 @@ resource "aws_security_group_rule" "computed_egress_with_source_security_group_i
type = "egress"

source_security_group_id = var.computed_egress_with_source_security_group_id[count.index]["source_security_group_id"]
ipv6_cidr_blocks = var.egress_ipv6_cidr_blocks
prefix_list_ids = var.egress_prefix_list_ids
description = lookup(
var.computed_egress_with_source_security_group_id[count.index],
Expand Down Expand Up @@ -747,7 +741,6 @@ resource "aws_security_group_rule" "egress_with_self" {
type = "egress"

self = lookup(var.egress_with_self[count.index], "self", true)
ipv6_cidr_blocks = var.egress_ipv6_cidr_blocks
prefix_list_ids = var.egress_prefix_list_ids
description = lookup(
var.egress_with_self[count.index],
Expand Down Expand Up @@ -780,7 +773,6 @@ resource "aws_security_group_rule" "computed_egress_with_self" {
type = "egress"

self = lookup(var.computed_egress_with_self[count.index], "self", true)
ipv6_cidr_blocks = var.egress_ipv6_cidr_blocks
prefix_list_ids = var.egress_prefix_list_ids
description = lookup(
var.computed_egress_with_self[count.index],
Expand Down