feat: Implement ingress and egress with prefix lists #258

andyshinn · 2022-09-20T19:50:05Z

Description

This is a reopening of pull request #226 which didn't get any movement. I am opening after forking and rebasing to see if we can get some movement on it as I would like the feature.

This feature aims at allowing the module to provision SG Rules by specifying explicitly the ingress or ingress rules with prefix lists. It also allows to unset a new variable enable_prefix_lists_cross_over which drives whether there should be cross over flow openings between the inputs (self, cidr blocks, or security groups) and the prefix lists.

Motivation and Context

I am creating security groups with prefix lists as ingress and egress targets.

Breaking Changes

How Has This Been Tested?

I have updated at least one of the examples/* to demonstrate and validate my change(s)
I have tested and validated these changes using one or more of the provided examples/* projects

I have executed pre-commit run -a on my pull request

I am still going through the testing parts (trouble getting pre-commit to run). But I am applying this to projects using my fork.

github-actions · 2022-10-21T00:12:48Z

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

andyshinn · 2022-10-21T16:28:29Z

Thanks, bot. It is still a desired PR.

github-actions · 2022-12-10T00:06:47Z

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

andyshinn · 2022-12-10T04:28:11Z

Thanks, bot. It is still a desired PR.

github-actions · 2023-01-11T00:06:45Z

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

andyshinn · 2023-01-11T05:09:10Z

Thanks, bot. It is still a desired PR.

github-actions · 2023-02-12T00:07:30Z

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

andyshinn · 2023-02-13T16:50:08Z

Thanks, bot. It is still a desired PR.

loicvolle

LGTM

keenobi · 2023-03-16T08:58:56Z

Hello !
Thanks for the PR, this is exactly what we are looking for ! 👍

@antonbabenko is it something that may block the merge ?

Best regards

github-actions · 2023-04-16T00:07:11Z

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

andyshinn · 2023-04-17T15:57:40Z

Thanks, bot. It is still a desired PR.

dokuur · 2023-05-15T14:16:23Z

@andyshinn , can you fix all conflicts? Maybe after that your PR will accepted

…ids and egress_with_prefix_list_ids

andyshinn · 2023-05-18T15:51:58Z

Rebased to fix conflicts.

antonbabenko

Looks rather good, but there are still a few things to do.

PS: Apologies that it took ages to review this PR.

examples/complete/main.tf

antonbabenko · 2023-05-18T19:36:52Z

main.tf

+  security_group_id = local.this_sg_id
+  type              = "ingress"
+
+  prefix_list_ids = var.ingress_prefix_list_ids


Suggested change

prefix_list_ids = var.ingress_prefix_list_ids

prefix_list_ids = var.ingress_with_prefix_list_ids

Or something along those lines, right?

Please verify in other resources, too.

I'm a little confused here. The ingress_with_prefix_list_ids is the list of custom rules to apply, not the list of prefix IDs. I was just following the template of the other ones which create a resource per rule (ingress_with_prefix_list_ids and then set the argument to the resource ID to apply to (ingress_prefix_list_ids). Let me know if I have confused something and if you could clarify.

You're right. I misunderstood the code.

variables.tf

w0rldart · 2023-06-01T07:26:14Z

What is missing for this PR to be merged?

andyshinn · 2023-06-01T15:04:18Z

I will fix the feedback items soon. I am busy last few weeks.

…rom-schniber

antonbabenko

LGTM

antonbabenko · 2023-06-06T00:03:02Z

main.tf

+  security_group_id = local.this_sg_id
+  type              = "ingress"
+
+  prefix_list_ids = var.ingress_prefix_list_ids


You're right. I misunderstood the code.

antonbabenko · 2023-06-06T00:35:47Z

Thank you @andyshinn !

## [5.1.0](v5.0.0...v5.1.0) (2023-06-06) ### Features * Implement ingress and egress with prefix lists ([#258](#258)) ([2e1cbcb](2e1cbcb))

antonbabenko · 2023-06-06T00:35:54Z

This PR is included in version 5.1.0 🎉

github-actions · 2023-07-06T02:22:03Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

andyshinn force-pushed the ashinn/support-prefix-list-custom-reules-from-schniber branch from 4749952 to bca1ce6 Compare September 20, 2022 19:50

github-actions bot added the stale label Oct 21, 2022

andyshinn force-pushed the ashinn/support-prefix-list-custom-reules-from-schniber branch 2 times, most recently from 63c3cdb to 1dc33e2 Compare October 21, 2022 16:27

andyshinn changed the title ~~Implement ingress and egress with prefix lists~~ feat: Implement ingress and egress with prefix lists Oct 21, 2022

github-actions bot removed the stale label Oct 22, 2022

andyshinn force-pushed the ashinn/support-prefix-list-custom-reules-from-schniber branch from 1dc33e2 to 7cc8ea3 Compare November 9, 2022 20:18

github-actions bot added the stale label Dec 10, 2022

github-actions bot removed the stale label Dec 11, 2022

github-actions bot added the stale label Jan 11, 2023

andyshinn force-pushed the ashinn/support-prefix-list-custom-reules-from-schniber branch from bcac86f to 3c0981f Compare January 11, 2023 05:09

github-actions bot removed the stale label Jan 12, 2023

github-actions bot added the stale label Feb 12, 2023

andyshinn force-pushed the ashinn/support-prefix-list-custom-reules-from-schniber branch 2 times, most recently from 8c27973 to ac51765 Compare February 13, 2023 17:00

github-actions bot removed the stale label Feb 14, 2023

loicvolle approved these changes Feb 14, 2023

View reviewed changes

github-actions bot added the stale label Apr 16, 2023

github-actions bot removed the stale label Apr 18, 2023

Samuel CHNIBER and others added 2 commits May 18, 2023 10:50

feature-terraform-aws-modules#224-Implement ingress_with_prefix_list_…

fec9eac

…ids and egress_with_prefix_list_ids

using prefix list in complete example

ff9164f

andyshinn force-pushed the ashinn/support-prefix-list-custom-reules-from-schniber branch from ac51765 to ff9164f Compare May 18, 2023 15:51

antonbabenko requested changes May 18, 2023

View reviewed changes

antonbabenko and others added 2 commits June 1, 2023 17:52

Merge branch 'master' into ashinn/support-prefix-list-custom-reules-f…

a1146dd

…rom-schniber

address feedback

b38eaf9

andyshinn requested a review from antonbabenko June 1, 2023 17:26

Fixed example

db44ac6

antonbabenko approved these changes Jun 6, 2023

View reviewed changes

antonbabenko added 2 commits June 5, 2023 17:05

Regenerated submodules code

637a1ce

Fixed EOF

5f17f4d

antonbabenko merged commit 2e1cbcb into terraform-aws-modules:master Jun 6, 2023
69 checks passed

antonbabenko pushed a commit that referenced this pull request Jun 6, 2023

chore(release): version 5.1.0 [skip ci]

43974e9

## [5.1.0](v5.0.0...v5.1.0) (2023-06-06) ### Features * Implement ingress and egress with prefix lists ([#258](#258)) ([2e1cbcb](2e1cbcb))

antonbabenko mentioned this pull request Jun 9, 2023

ingress_with_cidr_blocks do not use prefix_list_ids from map entry #281

Closed

1 task

github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement ingress and egress with prefix lists #258

feat: Implement ingress and egress with prefix lists #258

andyshinn commented Sep 20, 2022 •

edited

github-actions bot commented Oct 21, 2022

andyshinn commented Oct 21, 2022

github-actions bot commented Dec 10, 2022

andyshinn commented Dec 10, 2022

github-actions bot commented Jan 11, 2023

andyshinn commented Jan 11, 2023

github-actions bot commented Feb 12, 2023

andyshinn commented Feb 13, 2023

loicvolle left a comment

keenobi commented Mar 16, 2023

github-actions bot commented Apr 16, 2023

andyshinn commented Apr 17, 2023

dokuur commented May 15, 2023

andyshinn commented May 18, 2023

antonbabenko left a comment

antonbabenko May 18, 2023

andyshinn Jun 1, 2023

antonbabenko Jun 6, 2023

w0rldart commented Jun 1, 2023

andyshinn commented Jun 1, 2023

antonbabenko left a comment

antonbabenko Jun 6, 2023

antonbabenko commented Jun 6, 2023

antonbabenko commented Jun 6, 2023

github-actions bot commented Jul 6, 2023

	prefix_list_ids = var.ingress_prefix_list_ids
	prefix_list_ids = var.ingress_with_prefix_list_ids

feat: Implement ingress and egress with prefix lists #258

feat: Implement ingress and egress with prefix lists #258

Conversation

andyshinn commented Sep 20, 2022 • edited

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

github-actions bot commented Oct 21, 2022

andyshinn commented Oct 21, 2022

github-actions bot commented Dec 10, 2022

andyshinn commented Dec 10, 2022

github-actions bot commented Jan 11, 2023

andyshinn commented Jan 11, 2023

github-actions bot commented Feb 12, 2023

andyshinn commented Feb 13, 2023

loicvolle left a comment

Choose a reason for hiding this comment

keenobi commented Mar 16, 2023

github-actions bot commented Apr 16, 2023

andyshinn commented Apr 17, 2023

dokuur commented May 15, 2023

andyshinn commented May 18, 2023

antonbabenko left a comment

Choose a reason for hiding this comment

antonbabenko May 18, 2023

Choose a reason for hiding this comment

andyshinn Jun 1, 2023

Choose a reason for hiding this comment

antonbabenko Jun 6, 2023

Choose a reason for hiding this comment

w0rldart commented Jun 1, 2023

andyshinn commented Jun 1, 2023

antonbabenko left a comment

Choose a reason for hiding this comment

antonbabenko Jun 6, 2023

Choose a reason for hiding this comment

antonbabenko commented Jun 6, 2023

antonbabenko commented Jun 6, 2023

github-actions bot commented Jul 6, 2023

andyshinn commented Sep 20, 2022 •

edited