fix: Set correct port values for all-all

[robinbowes]

Description

Set the correct values for from_port and to_port when protocol is -1, as per the Terraform documentation.

Motivation and Context

Breaking Changes

The Terraform aws provider documentation for the protocol argument for the ingress block of the aws_security_group resource states:

If you select a protocol of -1 (semantically equivalent to all, which is not a valid value here), you must specify a from_port and to_port equal to 0

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • the complete example already uses -the all-all rule
• I have tested and validated these changes using one or more of the provided examples/* projects
  • I applied + destroyed the "complete" example

• I have executed pre-commit run -a on my pull request

[robinbowes]

Not really related to this PR, but I notice that when I run terraform init (using Terraform v1.0.11), Terraform creates a lock file (.terraform.lock.hcl) with this content:

# This file is maintained automatically by "terraform init".
# Manual edits may be lost in future updates.

provider "registry.terraform.io/hashicorp/aws" {
  version     = "5.41.0"
  constraints = ">= 3.29.0, >= 5.30.0"
  hashes = [
    "h1:SgIWBDBA1uNB/Y7CaLFeNX/Ju2xboSSQmRv35Vbi46M=",
  ]
}

I'm curious - where does the >= 5.30.0 constraint come from? The >= 3.29.0 constraint is in versions.tf but I can't find any reference to 5.30.0 anywhere.

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[github-actions]

This PR was automatically closed because of stale in 10 days