feat: Allow the creation of prefix-list rules, passing in unique prefix list IDs on a per rule basis #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t IDs on a per rule basis
mission-coliveros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is meant to address the complaints in this open issue
Motivation and Context
The existing codebase does not allow the creation of prefix-list based rules, where you can pass in prefix list IDs on a per-rule basis. You can only assign prefix list IDs at the module level, which is not particularly helpful.
Breaking Changes
Default values have been implemented, with the intention of not introducing any breaking changes
How Has This Been Tested?
I can start testing with examples, but I'd like to wait and see if this PR gets shut down before I put any more effort into it.
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request