Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the setup of fully private NAT Gateways #1060

Open
laserpedro opened this issue Apr 7, 2024 · 2 comments · May be fixed by #1072
Open

Enable the setup of fully private NAT Gateways #1060

laserpedro opened this issue Apr 7, 2024 · 2 comments · May be fixed by #1072

Comments

@laserpedro
Copy link

laserpedro commented Apr 7, 2024

Is your request related to a new offering from AWS?

  • No : the resource aws_nat_gatway enable the connectivity_type argument to be set to private so that not internet gateway is required when creating the private NAT gateway.

Is your request related to a problem? Please describe.

The module enables to setup VPCs following AWS best practices and I think that it should enable to implement the private NAT Gateway setup

Describe the solution you'd like.

Expose the variables that enables the setup referenced above. So add the connectivity_type and the other arguments relative to the setup of a private NAT Gateway.

I would be glad to create the pull request myself I you see any interest in this feature request. I believe that the fully private NAT Gateway can be a classic company setup and therefore we should enable this feature.

Workaround

The current workaround is to simply create the private NAT Gateway outside of the module and specifying the connectivity_type to private.

laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 7, 2024
@laserpedro laserpedro changed the title Enable the setup of private NAT Gateway Enable the setup of fully private NAT Gateway Apr 9, 2024
laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 13, 2024
laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 13, 2024
laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 13, 2024
@laserpedro laserpedro changed the title Enable the setup of fully private NAT Gateway Enable the setup of fully private NAT Gateways Apr 13, 2024
laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 16, 2024
laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 21, 2024
@bryantbiggs
Copy link
Member

if you have a PR, we can take a look

@laserpedro laserpedro linked a pull request Apr 25, 2024 that will close this issue
3 tasks
laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 25, 2024
laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 27, 2024
laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 27, 2024
laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 27, 2024
laserpedro pushed a commit to laserpedro/terraform-aws-vpc that referenced this issue Apr 27, 2024
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants