-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable the creation of private NAT gateways #1072
base: master
Are you sure you want to change the base?
feat: Enable the creation of private NAT gateways #1072
Conversation
fa0da22
to
c0a7184
Compare
vpc_peering_connection_id = resource.aws_ec2_transit_gateway_vpc_attachment.tgw_attach.id | ||
} | ||
|
||
module "vpc" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how has this been tested? does this example deploy without issue?
4ddf0cb
to
8f62e62
Compare
0666d56
to
1e86081
Compare
1e86081
to
71218ff
Compare
883377c
to
8566664
Compare
Hello @bryantbiggs ! Did you have the time to have a look at my PR ? Thank you ! |
Hi @laserpedro Nice job. Just one question, I was checking and the support for private nat gw is something I am looking forward in the module, unfortunately this does not take in account some scenarios where you can have public nat gw on your public subnets and private nat gw on you private subnets right? Thanks |
Hi @andre-lx , Thank you for your comment, much appreciated. |
fixes #1060
Description
Enable the setup of private NAT Gateways by exposing the native resource argument
connectivity_type
and the related arguments.Motivation and Context
If the module is used in the context of corporate network setup, a private nat gateway can be required since we are not created and internet gateway in the vpc.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request