Bugfix: Upgrade hclv2 to allow terraform-docs to read HCL containing provider functions
#770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovider functions Signed-off-by: Brittan DeYoung <32572259+brittandeyoung@users.noreply.github.com>
…unction to verify terraform-docs can properly parse Signed-off-by: Brittan DeYoung <32572259+brittandeyoung@users.noreply.github.com>
brittandeyoung
force-pushed
the
b-provider-functions-parse
branch
from
722c195
to
8d5f633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR does the following:
hclv2go package ( and necessary dependencies) to a version that supports reading the new provider defined functions as noted here: Namespaced functions hashicorp/hcl#639full-exampletest to validate that terraform-docs is now able to parse hcl containing provider functions.Fixes #766
I have:
make test.How has this code been tested
full-exampletest config. I then verified that tests related to that configuration were failing usingmake test.hclv2go package and then verified that the tests were now passing usingmake test.