chore(resourcehierarchy): disambiguate prj-c-logging and prj-c-billing-logs #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sleighton2022 can I get a review on this one? non-functional changes |
daniel-cit
approved these changes
May 31, 2024
accepting suggested changes from Daniel's review Co-authored-by: Daniel Andrade <dandrade@ciandt.com>
apeabody
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes one project name and moves one resource to another project for logical grouping where the implementation differs from the original design.
Change 1: improve unclear project names
prj-c-loggingwas intended to contain all the audit logs from across the org.prj-c-billing-logswas intended to contain the export of detailed cost data to BigQuery. "logs" is a misleading name, because logs are not involved. I proposedprj-c-billing-exportas a more clear name for the purpose.Change 2: location of billing account log sink
In v4 changes, we added a billing account log sink to collect admin activity logs related to changes on the Billing Account. This should be grouped into the same project as other admin activity logs from across the org, but was accidentally deployed to the project for cost data exports, so I've moved the sink destination to
prj-c-logging