fix: Relax assignment of backup_configuration when operating as a replica #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_instance_name (replica) to allow configuration, just not backups
OscarVanL
requested review from
isaurabhuttam,
imrannayer and
a team
as code owners
OscarVanL
changed the title
|
/gcbrun |
|
Hi @imrannayer, did that come back clear? |
|
/gcbrun |
1 similar comment
|
/gcbrun |
imrannayer
approved these changes
Apr 11, 2024
ps-occrp
pushed a commit
to ps-occrp/terraform-google-sql-db
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #590
In #556 and #559 I added the ability to configure the
master_instance_nameandinstance_typeon the maingoogle_sql_database_instancecreated by this module.The intent was to allow the module to be used for on-premises database migrations, where the primary instance would start as a replica and then later be promoted to the source.
During this change I disabled the assignment of
backup_configurationbecause the docs say:When an instance is configured with a
master_instance_name, the instance is operating as a replica, so cannot have backups enabled. This was why I restricted configuring these values.However, I was overzealous about which configuration items I blocked. For example, binary logging can be enabled on replicas without enabling backups (infact, it must be to enable to create replicas). The only config here I should have restricted is the
enabledoption, which this PR changes.