Update Terraform SDK to V2 #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed.
|
|
Build failed.
|
Closed
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
recheck |
|
Build failed.
|
ozerovandrei
force-pushed
the
sdk-v2
branch
2 times, most recently
from
d190d3f
to
0273ab7
Compare
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
|
Related issue: theopenlab/openlab#808 |
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
ozerovandrei
force-pushed
the
sdk-v2
branch
from
b394b00
to
48e7099
Compare
|
Build failed.
|
ozerovandrei
force-pushed
the
sdk-v2
branch
from
48e7099
to
6c6693f
Compare
|
Build failed.
|
ozerovandrei
force-pushed
the
sdk-v2
branch
from
6c6693f
to
7e573e0
Compare
|
Build failed.
|
ozerovandrei
force-pushed
the
sdk-v2
branch
from
7e573e0
to
47ba276
Compare
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
ozerovandrei
force-pushed
the
sdk-v2
branch
from
47ba276
to
de10539
Compare
|
Build failed.
|
Use v2.7.1 version of terraform-plugin-sdk. Cleanup imports. Change `validation.SingleIP()` -> `validation.IsIPAddress`, `validation.ValidateRFC3339TimeString` -> `validation.IsRFC3339Time`. Replace `Removed` Schema property with `Deprecated`. Provide context into CustomizeDiff functions. Use functions with the new signatures to configure the Provider with Terraform SDK V2. Add context into resourceImagesImageV2UpdateComputedAttributes. Fix gofmt in pathorcontents package. Fix networking_port_v2 datasource issue: "profile: StateFunc is extraneous, value should just be changed before setting on computed-only field" by removing custom StateFunc. Fix containerinfra_cluster_v1 resource issuze: "kubeconfig: TypeMap with Elem *Resource not supported, use TypeList/TypeSet with Elem *Resource or TypeMap with Elem *Schema" by changing type to Type.Schema and updating flattenContainerInfraV1Kubeconfig function. Change the deprecated "Providers" field of resource.Test to "ProviderFactories". Use CreateContext, ReadContext, UpdateContext, DeleteContext instead of deprecated resource functions. Use diag.Diagnostics and Context for those functions. Disable `TestAccComputeV2SecGroup_self`, `TestAccComputeV2SecGroup_lowerCaseCIDR`, `TestAccNetworkingV2Subnet_allocationPool` tests since SDK V2 currently does not support indexes into TypeSet. Disable `TestAccComputeV2FloatingIPAssociate_attachToFirstNetwork` test since SDK V2 fails with collection error. Add `image_name`, `power_state` attributes to `compute_instance_v2` datasource since we try to set them just like in resource. Convert blockstorage quotaset volume types map to map of strings before calling Set. Update `TestAccBlockStorageQuotasetV3_basic` volume types quotas. Disabled flacky `TestAccNetworkingV2Trunk_trunkUpdateSubports` test since it can fail with `PortInUse` error.
ozerovandrei
force-pushed
the
sdk-v2
branch
from
de10539
to
620bcbf
Compare
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use v2.7.1 version of terraform-plugin-sdk.
Cleanup imports.
Change
validation.SingleIP()->validation.IsIPAddress,validation.ValidateRFC3339TimeString->validation.IsRFC3339Time.Replace
RemovedSchema property withDeprecated.Provide context into CustomizeDiff functions.
Use functions with the new signatures to configure the Provider with
Terraform SDK V2.
Add context into resourceImagesImageV2UpdateComputedAttributes.
Fix gofmt in pathorcontents package.
Fix networking_port_v2 datasource issue: "profile: StateFunc is
extraneous, value should just be changed before setting on computed-only
field" by removing custom StateFunc.
Fix containerinfra_cluster_v1 resource issuze: "kubeconfig: TypeMap with
Elem *Resource not supported, use TypeList/TypeSet with Elem *Resource
or TypeMap with Elem *Schema" by changing type to Type.Schema and
updating flattenContainerInfraV1Kubeconfig function.
Change the deprecated "Providers" field of resource.Test to
"ProviderFactories".
Use CreateContext, ReadContext, UpdateContext, DeleteContext instead of
deprecated resource functions. Use diag.Diagnostics and Context for
those functions.
Disable
TestAccComputeV2SecGroup_self,TestAccComputeV2SecGroup_lowerCaseCIDR,TestAccNetworkingV2Subnet_allocationPooltests since SDK V2 currently does not support indexes into TypeSet.
Disable
TestAccComputeV2FloatingIPAssociate_attachToFirstNetworktestsince SDK V2 fails with collection error.
Add
image_name,power_stateattributes tocompute_instance_v2datasourcesince we try to set them just like in resource.
Convert blockstorage quotaset volume types map to map of strings before
calling Set.
Update
TestAccBlockStorageQuotasetV3_basicvolume types quotas.Disabled flacky
TestAccNetworkingV2Trunk_trunkUpdateSubportstest sinceit can fail with
PortInUseerror.