Update: enable OS_DEBUG #1246

till · 2021-05-13T13:40:32Z

when TF_LOG is debug/trace
enable this by default (person probably wants it)

Resolves: #1203

theopenlab-ci · 2021-05-13T16:42:11Z

Build succeeded.

terraform-provider-openstack-unittest : SUCCESS in 3m 20s
terraform-provider-openstack-acceptance-test : SUCCESS in 2h 59m 55s
terraform-provider-openstack-acceptance-test-admin : SUCCESS in 1h 08m 04s

ozerovandrei · 2021-05-22T12:33:20Z

openstack/provider.go

@@ -403,6 +406,13 @@ func Provider() terraform.ResourceProvider {
 		return configureProvider(d, terraformVersion)
 	}

+	// enforce OS_DEBUG when TF_LOG is 'DEBUG' or 'TRACE'


The idea is nice but I don't like the implementation when we rewrite some environment variables in the system to change the behaviour of the gophercloud/utils library.

I think that we need to configure logger in that library when we have DEBUG or TRACE loglevel.

https://github.com/gophercloud/utils/blob/master/terraform/auth/config.go#L182

There should be a way to configure it. Or maybe we need a PR to gophercloud/utils to configure logger (or using &osClient.DefaultLogger{} programmatically, without dealing with env variables.

I didn't think I was "rewriting" it as I am setting it when it's not set. But I'll have a look.

@ozerovandrei I made a PR over there: gophercloud/utils#153 — is this what you were thinking? I am not sure what the release cycle is, but I can re-work this PR when there is a release?

@ozerovandrei Can I just update the dependency in this PR?

Sure, you can update the dependency here.

@ozerovandrei reworked my approach, rebased and then also updated gophercloud/utils with go get github.com/gophercloud/utils@latest. Can you have a look again?

Hopefully didn't change much and kept all BC. The idea is to allow the terraform openstack provider to enable logging using the configuration struct, vs. using environment variables. Related: terraform-provider-openstack/terraform-provider-openstack#1246

theopenlab-ci · 2021-06-05T13:06:04Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 3m 06s
terraform-provider-openstack-acceptance-test : FAILURE in 6m 59s
terraform-provider-openstack-acceptance-test-admin : FAILURE in 10m 36s

till · 2021-06-05T13:33:36Z

On both builds, devstack fails on ubuntu-bionic:

2021-06-05 13:04:36.324892 | ubuntu-bionic | + echo 'Running devstack'
2021-06-05 13:04:36.324965 | ubuntu-bionic | Running devstack
2021-06-05 13:04:36.324977 | ubuntu-bionic | + echo '... this takes 10 - 15 minutes (logs in logs/devstacklog.txt.gz)'
2021-06-05 13:04:36.324987 | ubuntu-bionic | ... this takes 10 - 15 minutes (logs in logs/devstacklog.txt.gz)
2021-06-05 13:04:36.325106 | ubuntu-bionic | ++ date +%s
2021-06-05 13:04:36.326529 | ubuntu-bionic | + start=1622898276
2021-06-05 13:04:36.326555 | ubuntu-bionic | + /tmp/ansible/bin/ansible primary -f 5 -i /home/zuul/workspace/inventory -m shell -a 'cd '\''/opt/stack/new/devstack'\'' && sudo -H -u stack DSTOOLS_VERSION=0.4.0 stdbuf -oL -eL ./stack.sh 2>&1 executable=/bin/bash'
2021-06-05 13:04:40.083227 | ubuntu-bionic | ERROR: the main setup script run by this job failed - exit code: 2
2021-06-05 13:04:40.083324 | ubuntu-bionic |     please look at the relevant log files to determine the root cause
2021-06-05 13:04:40.083339 | ubuntu-bionic | Running devstack worlddump.py
2021-06-05 13:04:41.251973 | ubuntu-bionic | Cleaning up host
2021-06-05 13:04:41.252030 | ubuntu-bionic | ... this takes 3 - 4 minutes (logs at logs/devstack-gate-cleanup-host.txt.gz)
2021-06-05 13:05:08.322827 | ubuntu-bionic |  [WARNING]: No hosts matched, nothing to do
2021-06-05 13:05:11.342189 | ubuntu-bionic | Done.
2021-06-05 13:05:12.925314 | ubuntu-bionic | *** FAILED with status: 2
2021-06-05 13:05:23.455488 | ubuntu-bionic | ERROR
2021-06-05 13:05:23.455854 | ubuntu-bionic | {
2021-06-05 13:05:23.455951 | ubuntu-bionic |   "delta": "0:04:04.849504",
2021-06-05 13:05:23.456039 | ubuntu-bionic |   "end": "2021-06-05 13:05:12.926319",
2021-06-05 13:05:23.456106 | ubuntu-bionic |   "msg": "non-zero return code",
2021-06-05 13:05:23.456173 | ubuntu-bionic |   "rc": 2,
2021-06-05 13:05:23.456238 | ubuntu-bionic |   "start": "2021-06-05 13:01:08.076815"
2021-06-05 13:05:23.456303 | ubuntu-bionic | }
2021-06-05 13:05:23.497499 | 
2021-06-05 13:05:23.497616 | PLAY RECAP
2021-06-05 13:05:23.497718 | ubuntu-bionic | ok: 16 changed: 13 unreachable: 0 failed: 1 skipped: 15 rescued: 0 ignored: 1

Probably (hopefully) not related.

I had a look though:
https://logs.openlabtesting.org/logs/46/1246/5c77f96edec77bde7a3d76609a559177183198d4/check/terraform-provider-openstack-acceptance-test-admin/e9b5f2f/logs/devstack-gate-cleanup-host.txt

I can't tell exactly where it fails, so there is a command not found in the middle and it's grep'ing for too many things that don't exist. Nothing looks related to what I did. 🤷🏼

openstack/provider.go

frittentheke · 2021-06-29T12:14:47Z

@till this is really a nice feature.
Could you maybe rebase this once more and work in the changes @ozerovandrei asked for?

till · 2021-06-29T12:17:33Z

@frittentheke yes, will do — I hope I get to it all by Friday or earlier. Maybe during the ⚽ game tonight. :D

till · 2021-07-27T11:51:18Z

@frittentheke @ozerovandrei hope I addressed everything. Let me know!

till · 2021-08-03T12:29:44Z

Can anyone take a look? 👀

frittentheke · 2021-08-04T15:58:46Z

Can anyone take a look? eyes

Sorry @till for picking this up just now and thanks for keeping at it!

I built and tested the provider and things work just as expected.

But you are lacking the change to go.mod (bumping the dependency to github.com/gophercloud/utils containing your MR gophercloud/utils#153) ... I pulled in latest and it should look like this:

diff --git a/go.mod b/go.mod
index 0f37754e..711ddf1d 100644
--- a/go.mod
+++ b/go.mod
@@ -4,7 +4,7 @@ go 1.15
 
 require (
        github.com/gophercloud/gophercloud v0.17.1-0.20210517213536-0be823b69be8
-       github.com/gophercloud/utils v0.0.0-20210216074907-f6de111f2eae
+       github.com/gophercloud/utils v0.0.0-20210720165645-8a3ad2ad9e70
        github.com/hashicorp/terraform-plugin-sdk v1.17.2
        github.com/mitchellh/go-homedir v1.1.0
        github.com/stretchr/testify v1.7.0

till · 2021-08-09T13:09:26Z

@frittentheke Sorry, probably screwed up my rebase. Will fix.

frittentheke · 2022-01-21T15:33:46Z

@till I just remembered this PR when digging into an issue (#1307).

Could you maybe get this change rebased to finally close #1203 ?

- when TF_LOG is debug/trace (and OS_DEBUG is not set) - enable this by default (person probably wants it) Resolves: terraform-provider-openstack#1203

till · 2022-01-23T16:43:45Z

@frittentheke I tried my best to rebase it again. Can you or anyone else see if this can get integrated soon? Otherwise, feel free to pick the commits from my fork. I am also happy if this lands in the official code and I can stop patching it. :)

theopenlab-ci · 2022-01-23T18:08:22Z

Build failed.

terraform-provider-openstack-unittest-foo : SUCCESS in 4m 43s
terraform-provider-openstack-acceptance-test-foo : FAILURE in 44m 40s
terraform-provider-openstack-acceptance-test-admin-foo : FAILURE in 43m 34s

frittentheke · 2022-01-24T13:19:03Z

@ozerovandrei could you kindly take an other look at this. I quite like the change and usually do exactly that manually anyways.

till · 2022-02-01T08:44:04Z

@ozerovandrei sorry to bug, but can you take a look this week? Or is there someone else who can?

ozerovandrei

LGTM thank you @till

till · 2022-02-06T16:37:48Z

Thanks very much!

ozerovandrei requested changes May 22, 2021

View reviewed changes

This was referenced May 22, 2021

Update: enable logging via config hostwithquantum/gophercloud-utils#1

Closed

Update: enable logging via config gophercloud/utils#153

Merged

till force-pushed the chore-os_debug branch from 5a6bf1f to 5c77f96 Compare June 5, 2021 12:52

till requested a review from ozerovandrei June 5, 2021 13:33

ozerovandrei reviewed Jun 7, 2021

View reviewed changes

openstack/provider.go Show resolved Hide resolved

ozerovandrei reviewed Jun 7, 2021

View reviewed changes

openstack/provider.go Outdated Show resolved Hide resolved

till force-pushed the chore-os_debug branch 2 times, most recently from 048a90a to 8e8ecc7 Compare July 27, 2021 11:50

Update: enable debug logging in the provider

4e0e169

- when TF_LOG is debug/trace (and OS_DEBUG is not set) - enable this by default (person probably wants it) Resolves: terraform-provider-openstack#1203

till force-pushed the chore-os_debug branch from 8e8ecc7 to 4e0e169 Compare January 23, 2022 16:42

till requested a review from ozerovandrei January 23, 2022 16:45

Chore: update github.com/gophercloud/utils

d087c7f

ozerovandrei approved these changes Feb 6, 2022

View reviewed changes

ozerovandrei merged commit be44786 into terraform-provider-openstack:main Feb 6, 2022

till deleted the chore-os_debug branch February 6, 2022 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update: enable OS_DEBUG #1246

Update: enable OS_DEBUG #1246

till commented May 13, 2021

theopenlab-ci bot commented May 13, 2021

ozerovandrei May 22, 2021

till May 22, 2021

till May 22, 2021

till Jun 3, 2021

ozerovandrei Jun 5, 2021

till Jun 5, 2021

theopenlab-ci bot commented Jun 5, 2021

till commented Jun 5, 2021

frittentheke commented Jun 29, 2021

till commented Jun 29, 2021

till commented Jul 27, 2021

till commented Aug 3, 2021

frittentheke commented Aug 4, 2021 •

edited

till commented Aug 9, 2021

frittentheke commented Jan 21, 2022

till commented Jan 23, 2022

theopenlab-ci bot commented Jan 23, 2022

frittentheke commented Jan 24, 2022

till commented Feb 1, 2022

ozerovandrei left a comment

till commented Feb 6, 2022

Update: enable OS_DEBUG #1246

Update: enable OS_DEBUG #1246

Conversation

till commented May 13, 2021

theopenlab-ci bot commented May 13, 2021

ozerovandrei May 22, 2021

Choose a reason for hiding this comment

till May 22, 2021

Choose a reason for hiding this comment

till May 22, 2021

Choose a reason for hiding this comment

till Jun 3, 2021

Choose a reason for hiding this comment

ozerovandrei Jun 5, 2021

Choose a reason for hiding this comment

till Jun 5, 2021

Choose a reason for hiding this comment

theopenlab-ci bot commented Jun 5, 2021

till commented Jun 5, 2021

frittentheke commented Jun 29, 2021

till commented Jun 29, 2021

till commented Jul 27, 2021

till commented Aug 3, 2021

frittentheke commented Aug 4, 2021 • edited

till commented Aug 9, 2021

frittentheke commented Jan 21, 2022

till commented Jan 23, 2022

theopenlab-ci bot commented Jan 23, 2022

frittentheke commented Jan 24, 2022

till commented Feb 1, 2022

ozerovandrei left a comment

Choose a reason for hiding this comment

till commented Feb 6, 2022

frittentheke commented Aug 4, 2021 •

edited