Correctly delete openstack_networking_router_interface_v2 resources #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating multiple openstack_networking_router_interface_v2 resources for different IPv6 subnets in the same network, openstack will attach these to the same port on the router. On destroy the current implementation will pass the port_id to routers.RemoveInterface, which will trigger the deletion of the whole port, including other openstack_networking_router_interface_v2 resources on the same port. This commit changes this behaviour (so that only the correct router interface gets deleted) and adds a test case that ensures this does not break again in the future.
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
No idea why the status checks fail. I'm lost in the thousands of log lines. Can someone help with this? |
|
recheck |
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
ozerovandrei
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating multiple
openstack_networking_router_interface_v2resources for different IPv6 subnets in the same network, openstack will
attach these to the same port on the router.
On destroy the current implementation will pass the
port_idtorouters.RemoveInterface, which will trigger the deletion of the wholeport, including other
openstack_networking_router_interface_v2resourceson the same port.
This commit changes this behaviour (so that only the correct router interface
gets deleted) and adds a test case that ensures this does not break
again in the future.
Note: We were affected by this bug. In our case we deleted an
openstack_networking_router_interface_v2viaterraform destroy -target …, but terraform-provider-openstack silently deleted the whole port including another, importantopenstack_networking_router_interface_v2resource which was crucial for our production setup.