Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octavia: Add tags to loadbalancer #1301

Merged
merged 1 commit into from Dec 4, 2021
Merged

Octavia: Add tags to loadbalancer #1301

merged 1 commit into from Dec 4, 2021

Conversation

nikParasyr
Copy link
Collaborator

Add support for tags for openstack_lb_loadbalancer_v2
For #1300

@nikParasyr
Copy link
Collaborator Author

check lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 15, 2021

Build failed.

@ozerovandrei
Copy link
Member

recheck

@ozerovandrei
Copy link
Member

recheck lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 25, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 25, 2021

Build succeeded.

@ozerovandrei
Copy link
Member

recheck lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 4, 2021

Build failed.

@nikParasyr
Copy link
Collaborator Author

recheck lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 4, 2021

Build failed.

@nikParasyr
Copy link
Collaborator Author

recheck lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 15, 2021

Build failed.

@nikParasyr
Copy link
Collaborator Author

recheck lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 20, 2021

Build failed.

@nikParasyr
Octavia: Add tags to loadbalancer
1984365 
Add support for tags for openstack_lb_loadbalancer_v2
For terraform-provider-openstack#1300
@nikParasyr
Copy link
Collaborator Author

recheck lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 25, 2021

Build failed.

@nikParasyr
Copy link
Collaborator Author

@ozerovandrei I have 0 clue why the lbaas job is failing. It's not related to tests. I checked a bit devstack for possible updates that would affect us but couldnt find anything...

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 25, 2021

Build failed.

@nikParasyr
Copy link
Collaborator Author

recheck lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 29, 2021

Build failed.

@ozerovandrei
Copy link
Member

I can merge it if you sure it works and you tested it in some OpenStack installation.

@nikParasyr
Copy link
Collaborator Author

@ozerovandrei I run now the acceptance test that includes tags and it passed (Openstack Stein with octavia):

make testacc TEST=./openstack TESTARGS="-run=TestAccLBV2LoadBalancer_basic -count=1"                     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./openstack -v -run=TestAccLBV2LoadBalancer_basic -count=1 -timeout 120m
=== RUN   TestAccLBV2LoadBalancer_basic
--- PASS: TestAccLBV2LoadBalancer_basic (119.06s)
PASS
ok  	github.com/terraform-provider-openstack/terraform-provider-openstack/openstack	119.069s

I probably tested it as well before submitting, but it's over a month now so i cant recall 100%

ozerovandrei
ozerovandrei approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei ozerovandrei merged commit 10a2955 into terraform-provider-openstack:main Dec 4, 2021
@nikParasyr nikParasyr deleted the lb_tags branch December 7, 2021 13:59
@nikParasyr nikParasyr mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikParasyr @ozerovandrei