Retry reading DNS zone and Compute instance state after creation #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevents state mismatch in case of server errors
pbasov
changed the title
This was referenced Oct 25, 2021
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
Networking errors in tests are unrelated to changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some issues with our cloud which buckled under a high load, which resulted in a bunch of 504 errors.
Provider didn't handle the errors during async operations with DNS zones and Compute instances, which resulted in mismatched states when cloud resources were actually created, but didn't go into ACTIVE state before an intermittent API error.
This change let's the provider keep refreshing the state through 502 and 504 errors, to prevent missing resources in state, that are already present on the cloud.