Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag tempurl url attribute as sensitive #1305

Merged
merged 2 commits into from Nov 4, 2021

Conversation

wilas
Copy link
Contributor

@wilas wilas commented Oct 29, 2021

Tempurl URL shouldn't be visible in plaintext by default.

URL should be known only by those who received it explicit rather than everyone with ability to see terraform plan.
Tempurl might point to object with sensitive content.

nonsensitive() function can be used in case someone prefer display tempurl in plaintext in terraform plan/output.

Tempurl URL shouldn't be visible in plaintext by default.

URL should be known only by those who received it explicit rather than everyone with ability to see terraform plan.
Tempurl might point to object with sensitive content.

`nonsensitive()` function can be used in case someone prefer display tempurl in plaintext in terraform plan/output.
@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 29, 2021

@ozerovandrei
Copy link
Member

Networking errors in tests are unrelated to changes in this PR.

Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @wilas

@ozerovandrei ozerovandrei merged commit 4d884d1 into terraform-provider-openstack:main Nov 4, 2021
@wilas wilas deleted the patch-1 branch November 4, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants