Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Gophercloud #1315

Merged
merged 2 commits into from Nov 30, 2021
Merged

Bump Gophercloud #1315

merged 2 commits into from Nov 30, 2021

Conversation

pierreprinetti
Copy link
Contributor

Upgrade Gophercloud to v0.23.0 and its utils library to the
latest version available.

This patch is supposed to pick up all the bugfixes introduced in the library since v0.17.1.

@pierreprinetti
Bump Gophercloud
6bd5c49 
Upgrade Gophercloud to [v0.23.0][1] and its `utils` library to the
latest version available.

[1]: https://github.com/gophercloud/gophercloud/releases/tag/v0.23.0
@pierreprinetti
gophercloud v0.23.0 bump: Adapt the code
5d3f417
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 18, 2021

Build failed.

@pierreprinetti
Copy link
Contributor Author

recheck

@pierreprinetti pierreprinetti mentioned this pull request Nov 18, 2021
Merged
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 18, 2021

Build failed.

@pierreprinetti
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 22, 2021

Build failed.

@EmilienM
Copy link

No need to recheck, Manila shares failed to be created:

2021-11-22 12:59:42.714 | + /opt/stack/new/manila/devstack/plugin.sh:create_default_share_type:1 :   exit_trap

https://logs.openlabtesting.org/logs/15/1315/5d3f417e831a14bea1555a665b4d3c978069c0aa/check/terraform-provider-openstack-acceptance-test-foo/cdc8eeb/logs/devstacklog.txt

Someone will have to fix this.

@EmilienM
Copy link

Likely broken by https://review.opendev.org/c/openstack/devstack/+/780417

@EmilienM
Copy link

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 25, 2021

Build failed.

@EmilienM
Copy link

Now failing on Neutron trunks tests:
https://logs.openlabtesting.org/logs/15/1315/5d3f417e831a14bea1555a665b4d3c978069c0aa/check/terraform-provider-openstack-acceptance-test-foo/d840c80/test_results.html

But at least Manila issue seems solved now.

ozerovandrei
ozerovandrei approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @pierreprinetti

Trunk tests will be disabled #1323

@ozerovandrei ozerovandrei merged commit c7a923e into terraform-provider-openstack:main Nov 30, 2021
@pierreprinetti pierreprinetti deleted the bump_gophercloud branch December 1, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierreprinetti @EmilienM @ozerovandrei