Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack_images_image_v2: Make it possible to update image settings after resource creation #1341

Conversation

fitbeard
Copy link
Contributor

@fitbeard fitbeard commented Jan 4, 2022

This change makes usable feature introduced earlier in #1299
Tests were untouched because no new functionality was added.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 4, 2022

@fitbeard
Copy link
Contributor Author

fitbeard commented Jan 4, 2022

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 4, 2022

@fitbeard
Copy link
Contributor Author

fitbeard commented Jan 5, 2022

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 5, 2022

@fitbeard
Copy link
Contributor Author

fitbeard commented Jan 5, 2022

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 5, 2022

@fitbeard
Copy link
Contributor Author

fitbeard commented Jan 5, 2022

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 5, 2022

@fitbeard
Copy link
Contributor Author

fitbeard commented Jan 6, 2022

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 6, 2022

@fitbeard
Copy link
Contributor Author

fitbeard commented Jan 6, 2022

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 6, 2022

@fitbeard
Copy link
Contributor Author

fitbeard commented Jan 9, 2022

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 9, 2022

@fitbeard
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 11, 2022

@fitbeard
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 16, 2022

@fitbeard
Copy link
Contributor Author

fitbeard commented Jan 22, 2022

@ozerovandrei Can you review it? Regardless of the failing tests I think everything is very simple and clear here.

@fitbeard
Copy link
Contributor Author

recheck

Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei ozerovandrei merged commit acb7c70 into terraform-provider-openstack:main Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants