Be able to specify user_id when creating keypair

[smutel]

Implement #1230

[smutel]

Currently, I didn't implement the data part. I would like to have a review from someone first.

[smutel]

Could you please start the CI again ?

[ozerovandrei]

recheck

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest-foo : SUCCESS in 4m 42s
• terraform-provider-openstack-acceptance-test-foo : FAILURE in 3h 04m 40s
• terraform-provider-openstack-acceptance-test-admin-foo : SUCCESS in 1h 19m 52s

[smutel]

Could you please confirm that the CI is crashing due to my code ?

[ozerovandrei]

@smutel yeah, import test is failing:

2022-02-17 19:11:30.266925 | ubuntu-focal |     TestAccComputeV2Keypair_importBasic: import_openstack_compute_keypair_v2_test.go:12: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected
.
2022-02-17 19:11:30.267095 | ubuntu-focal |
2022-02-17 19:11:30.267233 | ubuntu-focal |         (map[string]string) {
2022-02-17 19:11:30.267297 | ubuntu-focal |         }
2022-02-17 19:11:30.268166 | ubuntu-focal |
2022-02-17 19:11:30.268284 | ubuntu-focal |
2022-02-17 19:11:30.268414 | ubuntu-focal |         (map[string]string) (len=1) {
2022-02-17 19:11:30.268561 | ubuntu-focal |          (string) (len=7) "user_id": (string) ""
2022-02-17 19:11:30.268611 | ubuntu-focal |         }

[smutel]

@smutel yeah, import test is failing:

2022-02-17 19:11:30.266925 | ubuntu-focal |     TestAccComputeV2Keypair_importBasic: import_openstack_compute_keypair_v2_test.go:12: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected
.
2022-02-17 19:11:30.267095 | ubuntu-focal |
2022-02-17 19:11:30.267233 | ubuntu-focal |         (map[string]string) {
2022-02-17 19:11:30.267297 | ubuntu-focal |         }
2022-02-17 19:11:30.268166 | ubuntu-focal |
2022-02-17 19:11:30.268284 | ubuntu-focal |
2022-02-17 19:11:30.268414 | ubuntu-focal |         (map[string]string) (len=1) {
2022-02-17 19:11:30.268561 | ubuntu-focal |          (string) (len=7) "user_id": (string) ""
2022-02-17 19:11:30.268611 | ubuntu-focal |         }

Except putting user_id here, I don't know how to resolve this ...

terraform-provider-openstack/openstack/import_openstack_compute_keypair_v2_test.go

Line 28 in 92ced13

ImportStateVerifyIgnore: []string{"private_key"},

resource id is the only parameter permitted by terraform import command so it will not be possible to import keypair resources from another user with admin account.

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest-foo : SUCCESS in 4m 50s
• terraform-provider-openstack-acceptance-test-foo : FAILURE in 3h 01m 36s
• terraform-provider-openstack-acceptance-test-admin-foo : SUCCESS in 1h 09m 48s

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest-foo : RETRY_LIMIT in 5m 05s
• terraform-provider-openstack-acceptance-test-foo : RETRY_LIMIT in 3h 01m 43s
• terraform-provider-openstack-acceptance-test-admin-foo : RETRY_LIMIT in 1h 10m 27s

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest-foo : RETRY_LIMIT in 4m 48s
• terraform-provider-openstack-acceptance-test-foo : RETRY_LIMIT in 3h 10m 09s
• terraform-provider-openstack-acceptance-test-admin-foo : RETRY_LIMIT in 59m 26s

[smutel]

Any ideas to pass the CI will be helpful ...

[ozerovandrei]

recheck

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest-foo : SUCCESS in 4m 28s
• terraform-provider-openstack-acceptance-test-foo : FAILURE in 3h 06m 20s
• terraform-provider-openstack-acceptance-test-admin-foo : SUCCESS in 1h 13m 22s

[ozerovandrei]

Error is unrelated:

TestAccSFSV2Share_update: resource_openstack_sharedfilesystem_share_v2_test.go:71: Step 1/4 error: Check failed: Check 5/5 error: Metadata does not match. Expected map[] but got value

[ozerovandrei]

LGTM, thank you @smutel

[smutel]

Is-it possible to have a new release with this feature please ?

[smutel]

Hello @ozerovandrei,

Did you plan to create a new release soon ?

Thanks.

[ozerovandrei]

Hello @smutel
It would be great to fix CI first to ensure that our provider works as expected prior releasing a new version: #1366
Unfortunately I haven't been able to find any time to do it yet.